MudDataGrid: Fix mobile loading indicator#13230
Merged
danielchalmers merged 1 commit intoMay 31, 2026
Merged
Conversation
Member
|
Thank you! |
This was referenced Jun 27, 2026
This was referenced Jul 2, 2026
This was referenced Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12091
The mobile table layout hides the normal header rows, but a fixed-header DataGrid still inherited the desktop sticky header offset for the loading row. That left the progress bar stuck 59px below the top of the hidden header and visually overlapping the first mobile data row.
This scopes the override to MudDataGrid responsive breakpoint classes so the loading cell uses
top: 0only while the mobile table layout is active. The existing desktop sticky-header offsets remain unchanged.Visual check:
.mud-table-loadingcomputedtopis0px, the progress bar ends at y=629.3, and the first body cell starts at y=629.3, so the loader no longer overlaps row content.Checklist:
Testing:
dotnet --version->10.0.107dotnet restore src/MudBlazor.UnitTests/MudBlazor.UnitTests.csprojdotnet test --project src/MudBlazor.UnitTests/MudBlazor.UnitTests.csproj --no-restore /p:SkipBunCompile=true -- --filter "FullyQualifiedName~DataGridLoadingProgress" --output Normal --no-ansi --hangdump --hangdump-timeout 30sdotnet tool run bun -- wrapper --version 1.3.14 -- install --frozen-lockfiledotnet build src/MudBlazor/MudBlazor.csproj --no-restore --nologodotnet restore src/MudBlazor.Docs.Server/MudBlazor.Docs.Server.csprojdotnet run --project src/MudBlazor.Docs.Server/MudBlazor.Docs.Server.csproj --no-restore --urls http://127.0.0.1:5012390x844against/components/datagrid#other-optionsdotnet format whitespace --no-restore --include MudBlazor/Styles/components/_datagrid.scssgit diff --checkNote: I used Codex to help inspect the code path and verify the local visual behavior, but I reviewed the final diff and ran the listed verification commands locally.