MudTableSortLabel: Add FullWidth parameter#13240
Conversation
| protected string Stylename => | ||
| new StyleBuilder() | ||
| .AddStyle("width", "100%", FullWidth) | ||
| .AddStyle(Style) | ||
| .Build(); |
There was a problem hiding this comment.
This inline style can be moved to src/MudBlazor/Styles/components/_table.scss by adding a class name to the CSS builder instead, e.g. mud-table-sort-label-full-width.
There was a problem hiding this comment.
Stylename can be reverted/removed now
|
Added the requested screenshot for the table sorting docs showing the new FullWidth usage on MudTableSortLabel:
|
|
Addressed the inline style review: FullWidth now adds the mud-table-sort-label-full-width class and width: 100% lives in _table.scss. I also updated the unit test to assert the class instead of the inline style. Tested in Docker with the TableSortLabel filter: 5 tests passed. |
|
All requested changes are addressed now, and the current CI run is green. Please let me know if anything else is needed from my side. |
| protected string Stylename => | ||
| new StyleBuilder() | ||
| .AddStyle("width", "100%", FullWidth) | ||
| .AddStyle(Style) | ||
| .Build(); |
There was a problem hiding this comment.
Stylename can be reverted/removed now
|
Addressed the latest review points in 9f4f8fa: removed the Stylename wrapper so the component uses the inherited Style parameter directly again, and added a negative test asserting mud-table-sort-label-full-width is absent when FullWidth is not enabled. Local validation: git diff --check passed. I also attempted the focused TableSortLabel test in a .NET SDK 10 container, but the restore/test process timed out locally; the temporary container/image artifacts were cleaned up, so CI is the source of truth for the full run. |
Adds a FullWidth parameter to MudTableSortLabel so the clickable sort label can fill the available table header width.
Fixes #11814
Tested with: