MudDataGrid: Focus selected filter when opening simple filter panel#13249
Merged
danielchalmers merged 5 commits intoJun 2, 2026
Merged
Conversation
danielchalmers
requested changes
May 31, 2026
| /// Opens the filter panel. | ||
| /// </summary> | ||
| public void OpenFilters() | ||
| public void OpenFilters(Guid? filterDefinitionIdToFocus = null) |
Member
There was a problem hiding this comment.
Changing the public OpenFilters() method signature to OpenFilters(Guid? = null) removes the zero-argument method at the binary level, so existing compiled consumers can hit MissingMethodException. We should keep public void OpenFilters() and add a separate internal/helper overload for focusing a specific filter.
Keep one regression test for the user-facing header filter path instead of asserting the internal OpenFilters overload and default fallback separately. The remaining test verifies that opening an existing Age column filter marks only the matching filter field for autofocus. This keeps coverage close to the reported behavior while avoiding brittle bUnit assertions around actual DOM focus plumbing, which does not translate cleanly in this component.
This was referenced Jun 27, 2026
This was referenced Jul 2, 2026
2 tasks
This was referenced Jul 6, 2026
3 tasks
This was referenced Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TO TEST:
This is the before:
This is the after:
Checklist: