Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix Title property for MudIconButton #4280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 23, 2022
Merged

Fix Title property for MudIconButton #4280

merged 2 commits into from
Apr 23, 2022

Conversation

IIARROWS
Copy link
Contributor

@IIARROWS IIARROWS commented Mar 26, 2022 •
edited
Loading

Add and fixes the Title property for Icons.

Description

Fixes issue #2818 and adds the Title property to MudFab.
The affected components are:

  • MudFab
  • MudIconButton (and all components that rely on it, passing a Title property)
  • MudToggleIconButton

How Has This Been Tested?

Update unit tests to look for the title property on the button tag instead of the SVG, as well as visually.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@JonBunator JonBunator added bug Unexpected behavior or functionality not working as intended bug-functional and removed bug-functional labels Mar 27, 2022
JonBunator
JonBunator approved these changes Apr 23, 2022
View reviewed changes
Copy link
Member

@JonBunator JonBunator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

@JonBunator JonBunator added this to the 6.0.10 milestone Apr 23, 2022
@JonBunator JonBunator merged commit a01f0b5 into MudBlazor:dev Apr 23, 2022
jammerware pushed a commit to jammerware/MudBlazor that referenced this pull request Sep 20, 2022
@IIARROWS @jammerware
MudIconButton: Fix title property | MudFab: Add title property (MudBl…
1454b98 
…azor#2818, MudBlazor#4280)
jammerware pushed a commit to jammerware/MudBlazor that referenced this pull request Sep 20, 2022
@IIARROWS @jammerware
MudIconButton: Fix title property | MudFab: Add title property (MudBl…
eee3e25 
…azor#2818, MudBlazor#4280)
jammerware pushed a commit to jammerware/MudBlazor that referenced this pull request Sep 20, 2022
@IIARROWS @jammerware
MudIconButton: Fix title property | MudFab: Add title property (MudBl…
4532b76 
…azor#2818, MudBlazor#4280)
jammerware pushed a commit to jammerware/MudBlazor that referenced this pull request Sep 20, 2022
@IIARROWS @jammerware
MudIconButton: Fix title property | MudFab: Add title property (MudBl…
7dc30af 
…azor#2818, MudBlazor#4280)
@WalterWillis WalterWillis mentioned this pull request Oct 18, 2022
Closed
2 tasks
3dots pushed a commit to 3dots/MudBlazor that referenced this pull request Mar 23, 2023
@IIARROWS @3dots
MudIconButton: Fix title property | MudFab: Add title property (MudBl…
94ee7ba 
…azor#2818, MudBlazor#4280)
ferraridavide pushed a commit to ferraridavide/MudBlazor that referenced this pull request May 30, 2023
@IIARROWS @ferraridavide
MudIconButton: Fix title property | MudFab: Add title property (MudBl…
b75ae26 
…azor#2818, MudBlazor#4280)
ilovepilav pushed a commit to ilovepilav/MudBlazor that referenced this pull request Nov 25, 2023
@IIARROWS @ilovepilav
MudIconButton: Fix title property | MudFab: Add title property (MudBl…
9f9190c 
…azor#2818, MudBlazor#4280)
@danielchalmers danielchalmers mentioned this pull request Mar 26, 2024
Closed
2 tasks
@danielchalmers danielchalmers mentioned this pull request Jun 1, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonBunator JonBunator JonBunator approved these changes

Assignees
No one assigned
Labels
bug Unexpected behavior or functionality not working as intended
Projects
None yet
Milestone
6.0.10
Development

Successfully merging this pull request may close these issues.
2 participants
@IIARROWS @JonBunator