MudDialog: Fix content not stretched in fullscreen mode #8743
Conversation
Apparently this was a regression which I expect was caused by the addition of a Focus Trap. The dialog content was expecting a flex parent, but the focus trap intercepted that. This adds classes to the MudFocusTrap and the container for the child content so you can apply styles and debug the layout easier by default. With those extra classes I applied flex to the intemediary components to make the dialog content grow as intended.
|
@henon Title may want to mention that this is a fix or that it only applies to fullscreen |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #8743 +/- ##
==========================================
+ Coverage 89.82% 90.09% +0.26%
==========================================
Files 412 419 +7
Lines 11878 12182 +304
Branches 2364 2397 +33
==========================================
+ Hits 10670 10975 +305
+ Misses 681 667 -14
- Partials 527 540 +13 ☔ View full report in Codecov by Sentry. |
|
Thanks! |
|
Hi, I am not sure if this is the right place to ask, if not, I am sorry. This is not yet in the newest version but a preview if I understand right? I am slightly confused because the similar issue with the cards #8933 is in the v.7 migration guide. I need to make sure the buttons stay at the same height/place in our dialog with a fixed height when the content changes and am wondering if I should try something custom or if it is going to be included soon because it isn't that urgent. Thank you for all the work you do, I really love Mudblazor :) |
|
@KimBorrmann Hi and thanks! This is included in v7 - if you're not seeing the right result please send me a https://try.mudblazor.com link and I'll take a look! |
Description
Apparently this was a regression which I expect was caused by the addition of a Focus Trap. The dialog content was expecting a flex parent, but the focus trap intercepted that.
This adds classes to the MudFocusTrap and the container for the child content so you can apply styles and debug the layout easier by default.
With those extra classes I applied flex to the intemediary components to make the dialog content grow as intended. Flex is the easier way to do this.
Resolves #5651
Resolves #6994
How Has This Been Tested?
visually
Type of Changes
Before
After
I had to hide the Scroll to Top FAB in those images because for some reason they are visible over the dialog.
Checklist
dev).