Thanks to visit codestin.com
Credit goes to github.com

Skip to content

KeyInterceptorService: Make KeyOptions immutable #9969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2024
Merged

KeyInterceptorService: Make KeyOptions immutable #9969

merged 1 commit into from
Oct 11, 2024

Conversation

ScarletKuro
Copy link
Member

@ScarletKuro ScarletKuro commented Oct 11, 2024 •
edited
Loading

Description

Was suggested here under the first point: #9896 (comment)

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added breaking change This change will require consumer code updates PR: needs review labels Oct 11, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.78%. Comparing base (28bc599) to head (de07ea2).
Report is 537 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #9969      +/-   ##
==========================================
+ Coverage   89.82%   90.78%   +0.95%     
==========================================
  Files         412      407       -5     
  Lines       11878    12584     +706     
  Branches     2364     2454      +90     
==========================================
+ Hits        10670    11424     +754     
+ Misses        681      598      -83     
- Partials      527      562      +35

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ScarletKuro ScarletKuro merged commit 322a3d8 into MudBlazor:dev Oct 11, 2024
5 checks passed
@ScarletKuro ScarletKuro deleted the keyoptions_immutable branch October 11, 2024 16:05
@ScarletKuro ScarletKuro mentioned this pull request Oct 11, 2024
Open
@ScarletKuro
Copy link
Member Author

Added to v8.0.0 Migration Guide #9953

LLauter pushed a commit to cannellamedia/MudBlazor that referenced this pull request Dec 16, 2024
@ScarletKuro @LLauter
KeyInterceptorService: Make KeyOptions immutable (MudBlazor#9969)
3f77776
@dependabot dependabot bot mentioned this pull request Aug 1, 2025
Closed
This was referenced Aug 18, 2025
Closed
Merged
@dependabot dependabot bot mentioned this pull request Aug 27, 2025
Merged
@dependabot dependabot bot mentioned this pull request Sep 8, 2025
Open
@dependabot dependabot bot mentioned this pull request Sep 22, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielchalmers danielchalmers danielchalmers approved these changes

Assignees
No one assigned
Labels
breaking change This change will require consumer code updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ScarletKuro @danielchalmers