RSeQC - Normalise junction saturation plot#3216
Merged
Merged
Conversation
vladsavelyev
approved these changes
Jun 6, 2025
vladsavelyev
left a comment
Contributor
There was a problem hiding this comment.
Looks good, thank you! 😌
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The junction saturation counts become hard to overview for multiple samples if they vary greatly in the number of junctions. For example, see the plot below generated using the current MultiQC.
The sample with the highest counts obscures all other samples. You could zoom in to observe the other samples, but it is not too practical to evaluate this metric quickly for a large number of samples.
To make this plot more useful, this PR normalises the junction counts to the total number of junctions, which brings all samples into the same scale to make the plot easier to evaluate
PS. I also removed a hint that is no longer relevant.