Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Scatter plot: allow configure marker symbol#3234

Merged
vladsavelyev merged 4 commits into
MultiQC:mainfrom
lucacozzuto:main
Jul 2, 2025
Merged

Scatter plot: allow configure marker symbol#3234
vladsavelyev merged 4 commits into
MultiQC:mainfrom
lucacozzuto:main

Conversation

@lucacozzuto

Copy link
Copy Markdown
Contributor
  • Code is tested and works locally (including with --strict flag)

I modified scatter.py and scatter.js to display symbols as well.

@ewels

ewels commented Jun 20, 2025

Copy link
Copy Markdown
Member

@multiqc-bot fix linting

@ewels

ewels commented Jun 20, 2025

Copy link
Copy Markdown
Member

Thanks for this! It would be good to also add it to the line graph plot type too, as the two are very similar.

@vladsavelyev

Copy link
Copy Markdown
Contributor

Thanks for the contribution!

I renamed the option to marker_symbol for consistency, and cleaned up the code a bit - otherwise looks good 👍

@vladsavelyev vladsavelyev added this to the v1.30 milestone Jul 2, 2025
@vladsavelyev vladsavelyev changed the title supporting symbols in scatter plot Scatter plot: allow configure marker symbol Jul 2, 2025
@vladsavelyev vladsavelyev enabled auto-merge (squash) July 2, 2025 10:28
@vladsavelyev vladsavelyev self-requested a review July 2, 2025 10:31
@vladsavelyev vladsavelyev merged commit 6a6b459 into MultiQC:main Jul 2, 2025
4 of 6 checks passed

@ewels ewels left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new feature needs to be documented 📚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants