Crop kspace transforms #210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull from branch shepp-logan-phantom
Codecov Report
@@ Coverage Diff @@
## main #210 +/- ##
==========================================
+ Coverage 80.79% 80.88% +0.09%
==========================================
Files 72 72
Lines 5317 5327 +10
==========================================
+ Hits 4296 4309 +13
+ Misses 1021 1018 -3
Continue to review full report at Codecov.
|
dbe6fc2 to
2b28b4b
Compare
* Fix RIM performance (#208) * Bring `modulus_if_complex` back with some fixes * protobuf issues * Bump version: 1.0.2 → 1.0.3-dev0 * Bump version: 1.0.3-dev0 → 1.0.3 * Adding JOSS paper badge
jonasteuwen
reviewed
Jun 7, 2022
jonasteuwen
reviewed
Jun 7, 2022
jonasteuwen
requested changes
Jun 7, 2022
Contributor
jonasteuwen
left a comment
There was a problem hiding this comment.
Some small comments. Nothing needs to change in the configs I presume? Did you try training some models to check performance against older models?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
CropKspacetransform implemented: Transforms to the image domain all coil data, crops to shape, transforms back to kspace domainCropAndMasktransform removed (had no cropping functionality)ComputeImagetransfrom implemented: computes image based on kspaceApplyMasktransform implementedbuild_mri_transformsreformatted to abide to the new transforms