( ( A and B ) or C ) and ( D or E ) case is converted to ( ( A and B) and C ) and ( D or E ). that's wrong #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@KangYongKyun , thank you for finding this error. We have re-evaluated our test and you are correct. This pull request should be merged. To fix the unit test, so that your pull request gets approved, please fix the unit test here: src/test/java/org/nlpcn/es4sql/QueryTest.java |
|
@jheimbouch Thank you for your answer. I fixed the second unit test's result. src/test/java/org/nlpcn/es4sql/QueryTest.java |
|
Thanks for your contribution! |
omershelef
added a commit
that referenced
this pull request
Apr 9, 2015
( ( A and B ) or C ) and ( D or E ) case is converted to ( ( A and B) and C ) and ( D or E ). that's wrong
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unit test(testMultipartWhere2)'s converted query is somethting wrong
testMultipartWhere2 => ( ( A and B ) or C ) and ( D or E ) case is converted to ( ( A and B) and C ) and ( D or E ). that's wrong
I fixed this bug.