test_horiz_interp: Don't over-allocate arrays#1607
Merged
Conversation
In the horiz_interp_type assignment 1x2d bicubic test, there are four allocatable arrays for which the number of elements allocated exceeds the number that get initialized: * `lon_src_1d` * `lat_src_1d` * `lon_out_1d` * `lat_out_1d` This PR shortens the sizes of the arrays to match the number of elements that get initialized.
laurenchilutti
approved these changes
Oct 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the horiz_interp_type assignment 1x2d bicubic test, there are four allocatable arrays for which the number of elements allocated exceeds the number that get initialized:
lon_src_1dlat_src_1dlon_out_1dlat_out_1dThis PR shortens the sizes of the arrays to match the number of elements that get initialized.
Fixes horiz_interp tests 23-24 with ifort using strict debug flags. It also fixes the tests with the Cray compiler. I'm requesting a careful review from @rem1776, because while this change does make the tests pass, I'm not sure whether or not the over-allocation may be a deliberate part of the test.
How Has This Been Tested?
horiz_interp tests build, run, and pass with CCE 18 on C5 and with ifort using the following debug flags:
Checklist:
make distcheckpasses