ANSI 301-2022: load profile schedules#1572
Merged
Merged
Conversation
Collaborator
Author
I decided to go for it. The simple fields are WaterWeekdayScheduleFractions, WaterWeekendScheduleFractions, and WaterMonthlyScheduleMultipliers (under BuildingOccupancy), and the detailed CSV column name is general_water_use. |
into ansi_301_2022_lighting_appl # Conflicts: # BuildResidentialHPXML/measure.xml # BuildResidentialScheduleFile/measure.xml # Changelog.md # HPXMLtoOpenStudio/measure.xml # ReportSimulationOutput/measure.xml # workflow/tests/base_results/results_workflow_simulations1.csv # workflow/tests/base_results/results_workflow_simulations1_bills.csv # workflow/tests/base_results/results_workflow_simulations2.csv # workflow/tests/base_results/results_workflow_simulations2_bills.csv
… not use dhw multiplier).
…/OpenStudio-HPXML into ansi_301_2022_lighting_appl
shorowit
approved these changes
Jan 26, 2024
This was referenced Jan 26, 2024
7 tasks
18 tasks
7 tasks
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Various schedule fractions/multipliers updates (e.g., appliances, lighting, fixtures, occupancy, ceiling fan).
Also allows the hot water recirculation pump schedule to be defined (w/defaults for no control, demand controlled, temperature controlled).
Default fridge schedule is now an actuated EMS program. Daily schedule is a function of hour and space temperature.
Questions / TODO:
schedule_files/occupancy-non-stochastic.csvwith ahot_water_recirculation_pumpcolumn? (And then we can updatetest_ruby_warning_messagesin test_validation.rb. Is this file updated manually? Edit: I manually added a constant "hot_water_recirculation_pump" column to the file, and update the test.constant_coefficientsandtemperature_coefficientsonly when all 3 of weekday fractions, weekend fractions, and monthly multipliers are not provided? I.e., if only weekday fractions are provided should we (a) default weekend fractions and monthly multipliers or (b) ignore weekday fractions and instead default constant/temperature coefficients? Edit: I'm going with (a) here.get_schedulemethod? Yes. Where/when do we use the new interior lighting schedule fractions? In OS-ERI.test_schedules.rbandtest_hotwater_appliance.rbuntil we figure this out. We may want to just hardcode expected values here? Update: I removed existing tests for fridge full load hrs, and replaced with simulation tests for energy use and schedule value sums.Checklist
PR Author: Check these when they're done. Not all may apply.
strikethroughand check any that do not apply.PR Reviewer: Verify each has been completed.
EPvalidator.xml) has been updatedopenstudio tasks.rb update_hpxmls)HPXMLtoOpenStudio/tests/test*.rband/orworkflow/tests/test*.rb)openstudio tasks.rb update_measureshas been run