Update Other, TV, and Ceiling Fan stochastic schedules#1634
Conversation
| plugload_other_weekday_sch = Schedule.validate_values(Constants.PlugLoadsOtherWeekdayFractions, 24, 'weekday') | ||
| plugload_other_weekend_sch = Schedule.validate_values(Constants.PlugLoadsOtherWeekendFractions, 24, 'weekend') | ||
| plugload_other_monthly_multiplier = Schedule.validate_values(Constants.PlugLoadsOtherMonthlyMultipliers, 12, 'monthly') |
There was a problem hiding this comment.
Should we update these to follow Table C.3(1) of ANSI/RESNET/ICC 301-2022 Addendum C?
There was a problem hiding this comment.
The CI comparison artifacts show how little difference we're talking here.
There was a problem hiding this comment.
The CI only really shows annual results; this makes a huge change to the timeseries results. Are you sure you want to do this?
Before:
After:
There was a problem hiding this comment.
Right, for Other and TV we're moving to constant monthly multipliers.
| def self.PlugLoadsTVWeekdayFractions | ||
| return '0.014, 0.007, 0.004, 0.003, 0.004, 0.006, 0.010, 0.015, 0.020, 0.025, 0.028, 0.031, 0.033, 0.038, 0.042, 0.046, 0.054, 0.062, 0.080, 0.110, 0.132, 0.125, 0.077, 0.034' | ||
| end | ||
|
|
||
| def self.PlugLoadsTVWeekendFractions | ||
| return '0.014, 0.007, 0.004, 0.003, 0.004, 0.006, 0.010, 0.015, 0.020, 0.025, 0.028, 0.031, 0.033, 0.038, 0.042, 0.046, 0.054, 0.062, 0.080, 0.110, 0.132, 0.125, 0.077, 0.034' | ||
| end |
There was a problem hiding this comment.
Should we adopt the separate/distinct "ATUS TVs weekday" and "ATUS TV weekend" schedule fractions from which these "average" schedule fractions were derived?
There was a problem hiding this comment.
Looks like most other categories have the same schedule fractions between weekday and weekend.
There was a problem hiding this comment.
@shorowit : I could have sworn we had weekday/weekend schedules broken out at one point. Maybe I am getting confused with the stochastic schedule generator. There are significant schedule differences between weekday and weekends for TVs (and other schedules). I would like the schedules broken out by weekday and weekend. To me, it seems relevant to better capture reality, but I understand if we stay consistent with ANSI/RESNET/ICC 301.
shorowit
left a comment
There was a problem hiding this comment.
Code changes look reasonable to me.
|
Checklist:
|
|
New comparisons after making recent changes. Before: After: |
Pull Request Description
Update the stochastic schedule generator to:
weather)Checklist
PR Author: Check these when they're done. Not all may apply.
strikethroughand check any that do not apply.PR Reviewer: Verify each has been completed.
Schematron validator (EPvalidator.xml) has been updatedopenstudio tasks.rb update_hpxmls)HPXMLtoOpenStudio/tests/test*.rband/orworkflow/tests/test*.rb)Documentation has been updatedopenstudio tasks.rb update_measureshas been run