Add a helper method to enable/disable plugins during staging of Eiger detectors#23
Open
Max Rakitin (mrakitin) wants to merge 1 commit intomainfrom
Open
Add a helper method to enable/disable plugins during staging of Eiger detectors#23Max Rakitin (mrakitin) wants to merge 1 commit intomainfrom
Max Rakitin (mrakitin) wants to merge 1 commit intomainfrom
Conversation
jklynch
approved these changes
Jan 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During today's CHX visit with Oksana Ivashkevych (@oksanagit), jklynch, Abby Giles (@AbbyGi), Michael Hart (@MikeHart85) over zoom and Lutz in person, we tried this method to disable plugins during the staging process of the
eiger1m_singledetector to speed up the acquisition process:We also figured out the non-blocking plugin mode was only enabled for
eiger4m_single, but not for the other 2 detectors (eiger500k_singleandeiger1m_single). de6e031 resolved it. We did a few tests with manipulation of the['roi1', 'roi2', 'roi3', 'roi4', 'stats1', 'stats2', 'stats3', 'stats4', 'stats5', 'proc1', 'image']plugins, and the results are as follows:bsuirestart, and ~6.8s for the subsequent runs;bsuirestart, and ~6.8s for the subsequent runs.The last 2 cases were comparable in terms of the speed of the scan, but when all plugins are enabled/non-blocking, the resource use is significantly higher than when the plugins are disabled. So, the current PR's update is to provide a way to disable the plugins when needed (they are enabled by default).
Usage:
This needs to be tested thoroughly before going to production, preferably with the beam.