Prevent beamline energy from changing with xbpm feedback ON - #51
Open
Andi Barbour (ambarb) wants to merge 2 commits into
Open
Prevent beamline energy from changing with xbpm feedback ON#51Andi Barbour (ambarb) wants to merge 2 commits into
Andi Barbour (ambarb) wants to merge 2 commits into
Conversation
Andi Barbour (ambarb)
requested review from
JGoodrichBNL and
Juan Marulanda (jmaruland)
September 12, 2026 00:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The XPBM feedback should be off when moving beamline energy at CHX because the beamline was designed to accept the vertical shift in the beam position - no correcting optics downstream of the dcm to do this.
Blinding turning off feedback because Andrei Fluerasu (@afluerasu) suggested not to try to make "too smart" and turn the feedback back on if it was ON at the start of the energy move.
Will make an issue associated with 2 other xbpm devices and other bits and pieces of code to try to make 1 bpm device to do all things.
Next steps includes making a proper ophyd device to move the beamline energy (with the ivu - undulator).