Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Move locking endpoints to admin #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jul 24, 2025
Merged

Move locking endpoints to admin #195

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
8e1af58
Add proposal locking and unlocking endpoints to admin API
stuartcampbell Jul 23, 2025
7c61433
Rename test_proposal_api.py to test_admin_api.py and improve code for…
stuartcampbell Jul 23, 2025
1b10835
Update proposal endpoints to include admin path prefix
stuartcampbell Jul 23, 2025
e72999c
Refactor imports in admin API and test files for consistency
stuartcampbell Jul 23, 2025
ecf3013
Not sure these should be a tuple
stuartcampbell Jul 23, 2025
7300cee
Use admin role for api key in tests
nmaytan Jul 23, 2025
7c6a176
Update names in cycle exists test
nmaytan Jul 23, 2025
9a0aabf
Fix query params in test_lock_and_unlock_proposals
nmaytan Jul 23, 2025
3eda171
Fix admin creation flow in conftest
nmaytan Jul 23, 2025
ce294a4
Apply ruff, fix import
nmaytan Jul 23, 2025
1977e85
Fix variables in admin tests
nmaytan Jul 23, 2025
0b09fb9
Fix admin auth dependency
nmaytan Jul 24, 2025
f959457
Use pagination in lock endpoints, minor cleanups
nmaytan Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update names in cycle exists test
  • Loading branch information
@nmaytan
nmaytan committed Jul 23, 2025
commit 7c6a176720356c739f200f70ebdb6b7a33d1d905
8 changes: 4 additions & 4 deletions src/nsls2api/tests/services/test_facility_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,8 @@ async def test_cycle_year():

@pytest.mark.anyio
async def test_cycle_exists():
cycle = await facility_service.cycle_exists(cycle_name = valid_cycle_name, facility = "nsls2")
assert cycle == True
cycle_exists = await facility_service.cycle_exists(cycle_name = valid_cycle_name, facility = "nsls2")
assert cycle_exists == True

fake_cycle = await facility_service.cycle_exists(cycle_name = "fake", facility = "nsls2")
assert fake_cycle == False
invalid_cycle_exists = await facility_service.cycle_exists(cycle_name = "invalid_cycle", facility = "nsls2")
assert invalid_cycle_exists == False