Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@plajjan
Copy link
Member

@plajjan plajjan commented Apr 23, 2020

This is the kind of commit I don't personally like. It mixes content changes
with formatting changes (line wrapping, tab -> spaces in lists etc) making it
harder to review. Apologies.

  • improved wording in a lot of place
  • tried to make text more concise, yet it is longer now as there is more
    information.
  • encourage GitLab over GitHub
    • inline with what has been discussed among librarians
  • remove mention of DCO compliance checking - there is no bot that forces
    compliance on Git(Lab|Hub) so no reason mentioning it

This is the kind of commit I don't personally like. It mixes content changes
with formatting changes (line wrapping, tab -> spaces in lists etc) making it
harder to review. Apologies.

- improved wording in a lot of place
- tried to make text more concise, yet it is longer now as there is more
  information.
- encourage GitLab over GitHub
  - inline with what has been discussed among librarians
- remove mention of DCO compliance checking - there is no bot that forces
  compliance on Git(Lab|Hub) so no reason mentioning it
@plajjan
Copy link
Member Author

plajjan commented Apr 23, 2020

@JohanVikman / @jabelk yo, plxz to read!

@JohanVikman
Copy link
Contributor

@plajjan we should mention that a repository description should be added. So that we don't have a cryptic name without a description.

Avoid repetition across paragraphs on why GitLab is better than GitHub.

Added section encouraging users to fill in repository description since that's
quite helpful for anyone browsing through the list of repos.
@plajjan
Copy link
Member Author

plajjan commented Apr 23, 2020

I believe I have addressed all the comments. Please have a look at the updated content!

@plajjan
Copy link
Member Author

plajjan commented Apr 24, 2020

@JohanVikman @jabelk any further comments or good to merge? :)

@JohanVikman
Copy link
Contributor

Looks good!

@plajjan
Copy link
Member Author

plajjan commented May 1, 2020

I'll go ahead and merge this. We can always update later on if there's anything we missed here.

@plajjan plajjan merged commit 12c86ce into master May 1, 2020
@plajjan plajjan deleted the update-readme-for-gitlab-etc branch May 1, 2020 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants