-
Notifications
You must be signed in to change notification settings - Fork 13
Eolofsso/ENG-37149-webui-doc #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cohult
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIce!
|
@cohult Did you read the changes carfully? I am a documentation novice and didn't get that gitbook plugin for pretty code rendering to work.. So I hope formatting and styling looks proper. |
ahcsco
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noticed a need for couple of small corrections.
|
@EdvinOlofsson , to spare us from checking formatting and styling, you can merge your markdown to the test-n-play branch and then to go to the gitbook editor for a preview: https://app.gitbook.com/o/zCWEO4HUVOjwxqT5Hla6/s/MCFXLJGKRQEW4n8TBkyC/development/advanced-development/web-ui-development/json-rpc-api |
|
@EdvinOlofsson , Also, since you are editing only a single Markdown page here and you want to preview the five GitBook extensions, next time I suggest you use the GitBook editor to make the changes. After you merged the changes done in the GitBook editor to main, you can get the commit id from here (GitHub) and cherry-pick when backporting to 6.6, 6.5, 6.4 etc branches. |
|
I see your suggestions @cohult Thanks for the detailed tips! |
|
I've pushed PR feedback fixes now. (minor typos, thanks for reading carefully!) |
|
@EdvinOlofsson, definitely good enough. The more we use the tailf repo type of commit messages and branch names the better. Good to point to the ENG ticket. |
Modernize WebUI development documentation with working vanilla JS examples