Declare free-threaded Python support on the python_function plugin.#6289
Conversation
Signed-off-by: Rostan Tabet <[email protected]>
Greptile SummaryThis PR completes DALI's free-threaded Python support by adding Confidence Score: 5/5This PR is safe to merge; all changes are correct, minimal, and consistent with the existing pattern in The core C++ change mirrors a pattern already in production. Script cleanup is straightforward. No P0/P1 issues identified; all remaining observations are P2 or lower and do not block merge. No files require special attention. Important Files Changed
|
Signed-off-by: Rostan Tabet <[email protected]>
Signed-off-by: Rostan Tabet <[email protected]>
Signed-off-by: Rostan Tabet <[email protected]>
|
!build |
|
CI MESSAGE: [48400360]: BUILD STARTED |
|
CI MESSAGE: [48400360]: BUILD PASSED |
…6289) * Declare free-threaded Python support on the python_function plugin * Stop setting PYTHON_GIL=0 to run the tests * Add dynamic mode multithreading tests to the free-threading test suite * Add a test making sure that DALI doesn't force-enable the GIL --------- Signed-off-by: Rostan Tabet <[email protected]>
Category:
Other (e.g. Documentation, Tests, Configuration)
Description:
The DALI backend Pybind11 extension already declares support for free-threaded Python. This PR does the same for
python_function_plugin. This is the missing piece for full free-threaded Python support.Since
python_function_pluginis always transitively imported, not declaring free-threaded support results in the GIL always being re-enabled for DALI:Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A