Add readme for direct bindings #5216
Merged
+44
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!build |
|
Review updated until commit 116baac Description
Changes walkthrough 📝
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
jjsjann123
approved these changes
Sep 25, 2025
python/python_direct/README.md
Outdated
|
|
||
| ## How to add new Operation? | ||
| * Add operation to `python_direct/ops.cpp` with docstring. | ||
| * If operations corresponds with a new Expr node, add `void handle(const SomeOp*) final` to `python_direct/python_translate.cpp`. |
There was a problem hiding this comment.
naive question: is an Operation not necessarily an Expr?
There was a problem hiding this comment.
broadcast_in_dim is a composite operation of BroadcastOp and ExpandOp. You may not need to add a handle function for composite operations.
| 3. Add output values for Expr node to `visited_vals_`. | ||
| 4. Create dynamic scalar input arguments. This step is for view and expand operations. TensorView input arguments are handled via DAG traversal. Constant scalars are added directly to python defintion. | ||
| 5. Use `PythonPrinter::generateOperation` if the operation only uses positional arguments. This is mainly used for unary and binary operations. | ||
| 6. Use `PythonPrinter::generateKwargsOperation` if the operation uses keyword arguments. If none of the keyword arguments have default arguments, create a static vector of strings. If some of the keyword arguments have default arguments, create a vector of KeywordArgument. The KeywordArgument struct hold default values for keyword arguments. Use `std::nullopt` for keyword arguments without default values. |
There was a problem hiding this comment.
👏 nice to have.
though I felt the examples in python_translate.cpp was already pretty decent. 😜
1c0dc6f to
116baac
Compare
|
!build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.