Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Revert "Convert python benchmarks to direct bindings except benchmark_overlap.py" #5219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Revert "Convert python benchmarks to direct bindings except benchmark_overlap.py" #5219

wants to merge 1 commit into from
+69 −229

Conversation

rdspring1
Copy link
Collaborator

Reverts #5139

!test --pybench didn't actually test any of the python benchmarks, which actually are broken by this PR.

@rdspring1
Copy link
Collaborator Author

!test

@github-actions GitHub Actions
Copy link

Description

  • Revert import changes from nvfuser_direct to nvfuser

  • Remove deprecated nvfuser_direct/benchmark_utils.py file

  • Restore original module imports for FusionDefinition and utilities

  • Fix benchmark functionality broken by direct bindings conversion

Changes walkthrough 📝

Relevant files
Bug fix
37 files
conftest.py
Revert nvfuser_direct imports to nvfuser                                 
+2/-2     
core.py
Restore nvfuser imports and remove direct bindings             
+3/-3     
global_params.py
Revert DataType and DEVICE_PROPERTIES imports                       
+2/-2     
test_adaptive_layernorm_host.py
Revert FusionDefinition import to nvfuser                               
+1/-1     
test_many_pointwise_ops_host.py
Restore nvfuser and torch_dtype_to_nvfuser_dtype imports 
+2/-2     
test_many_segments_host.py
Revert FusionDefinition import to original module               
+1/-1     
normalization.py
Revert FusionDefinition and dtype utility imports               
+2/-2     
test_broadcast_add_fwd.py
Restore standard nvfuser imports                                                 
+2/-2     
test_cat.py
Revert FusionDefinition import to nvfuser                               
+1/-1     
test_dropout_layernorm_bwd.py
Restore nvfuser module imports                                                     
+2/-2     
test_dropout_layernorm_fwd.py
Revert to original nvfuser imports                                             
+2/-2     
test_dropout_rmsnorm_bwd.py
Restore standard FusionDefinition import                                 
+2/-2     
test_dropout_rmsnorm_fwd.py
Revert imports to nvfuser package                                               
+2/-2     
test_gelu_bwd.py
Restore original nvfuser imports                                                 
+2/-2     
test_gelu_bwd_reduction.py
Revert FusionDefinition and dtype imports                               
+2/-2     
test_gelu_fwd.py
Restore standard nvfuser module imports                                   
+2/-2     
test_groupnorm_fwd.py
Revert to original FusionDefinition import                             
+2/-2     
test_huggingface_attn_bwd.py
Restore nvfuser imports from main package                               
+2/-2     
test_huggingface_attn_fwd.py
Revert imports to standard nvfuser module                               
+2/-2     
test_layernorm_bwd.py
Restore original FusionDefinition import                                 
+2/-2     
test_layernorm_fwd.py
Revert to standard nvfuser imports                                             
+2/-2     
test_matmul.py
Restore FusionDefinition import from nvfuser                         
+1/-1     
test_nanogpt_attn_bwd.py
Revert imports to original nvfuser module                               
+2/-2     
test_nanogpt_attn_fwd.py
Restore standard nvfuser package imports                                 
+2/-2     
test_pointwise_mul.py
Revert FusionDefinition and dtype imports                               
+2/-2     
test_reduction.py
Restore original nvfuser module imports                                   
+2/-2     
test_reduction_epilogue.py
Revert to standard FusionDefinition import                             
+2/-2     
test_rmsnorm_bwd.py
Restore nvfuser imports from main package                               
+2/-2     
test_rmsnorm_fwd.py
Revert imports to original nvfuser module                               
+2/-2     
test_scale_bias_relu_bwd.py
Restore standard FusionDefinition import                                 
+2/-2     
test_scale_bias_relu_fwd.py
Revert to nvfuser package imports                                               
+2/-2     
test_silu_mul_bwd.py
Restore original nvfuser module imports                                   
+2/-2     
test_silu_mul_fwd.py
Revert FusionDefinition and dtype imports                               
+2/-2     
test_softmax_bwd.py
Restore standard nvfuser imports                                                 
+2/-2     
test_softmax_fwd.py
Revert to original FusionDefinition import                             
+2/-2     
test_transpose.py
Restore nvfuser module imports                                                     
+2/-2     
benchmark_utils.py
Remove deprecated benchmark utils module                                 
+0/-160 

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🧪 PR contains tests
⚡ No major issues detected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjsjann123 jjsjann123 jjsjann123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rdspring1 @jjsjann123