Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix saving issue on new transformers w FSDP2 (for Release 0.37) #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AAnoosheh merged 1 commit into from
Oct 8, 2025
Merged

Fix saving issue on new transformers w FSDP2 (for Release 0.37) #414

AAnoosheh merged 1 commit into from
Oct 8, 2025

Conversation

@AAnoosheh
Copy link
Contributor

@AAnoosheh AAnoosheh commented Oct 8, 2025

What does this PR do?

Type of change: Bug Fix

Overview: ?

Usage

# Add a code snippet demonstrating how to use this

Testing

Example run

Before your PR is "Ready for review"

  • Make sure you read and follow Contributor guidelines and your commits are signed.
  • Is this change backward compatible?: Y
  • Did you write any new necessary tests?: N
  • Did you add or update any necessary documentation?: N
  • Did you update Changelog?: N

Additional Information

@AAnoosheh AAnoosheh self-assigned this Oct 8, 2025
@AAnoosheh AAnoosheh requested a review from a team as a code owner October 8, 2025 16:09
@AAnoosheh AAnoosheh changed the base branch from main to release/0.37.0 October 8, 2025 16:10
@AAnoosheh AAnoosheh requested review from a team as code owners October 8, 2025 16:10
@AAnoosheh AAnoosheh requested review from Edwardf0t1, i-riyad, yeyu-nvidia, ynankani and yueshen2016 and removed request for a team October 8, 2025 16:10
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 8, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch aanoosheh/fix-distill-example-0.37

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@AAnoosheh AAnoosheh force-pushed the aanoosheh/fix-distill-example-0.37 branch from 760c04b to 5782e61 Compare October 8, 2025 16:11
@AAnoosheh AAnoosheh enabled auto-merge (squash) October 8, 2025 16:19
@codecov
Copy link

codecov bot commented Oct 8, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.08%. Comparing base (7f8acb5) to head (5782e61).
⚠️ Report is 4 commits behind head on release/0.37.0.

Additional details and impacted files 
@@               Coverage Diff               @@
##           release/0.37.0     #414   +/-   ##
===============================================
  Coverage           74.08%   74.08%           
===============================================
  Files                 171      171           
  Lines               17388    17388           
===============================================
  Hits                12882    12882           
  Misses               4506     4506

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AAnoosheh AAnoosheh merged commit df0882a into release/0.37.0 Oct 8, 2025
27 checks passed
@AAnoosheh AAnoosheh deleted the aanoosheh/fix-distill-example-0.37 branch October 8, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevalmorabia97 kevalmorabia97 kevalmorabia97 approved these changes

Assignees

@AAnoosheh AAnoosheh

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AAnoosheh @kevalmorabia97