fix(analyzer): gate AE3 and AE4 on text content - #422
Merged
Merged
Conversation
rng1995
approved these changes
Aug 24, 2026
rng1995
left a comment
Collaborator
There was a problem hiding this comment.
[SkillSpector Review]\n\nApproved. Gating AE3/AE4 on textual content removes binary/opaque false positives while retaining archive-integrity checks and text-based mixed-script detection. The misleading-extension regression is especially useful. Current required checks pass.
Member
|
Powered by Codex: PR council review result. This is a triage signal, not a maintainer approval.
|
Signed-off-by: Rod Boev <[email protected]>
Signed-off-by: Rod Boev <[email protected]>
Signed-off-by: Rod Boev <[email protected]>
rodboev
force-pushed
the
pr/ae34-opaque-content-413
branch
from
August 25, 2026 12:12
2ba5984 to
2382217
Compare
Contributor
Author
|
Rebased onto current main and force-pushed as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AE3 and AE4 no longer inspect decoded cache text for artifacts classified as binary or opaque. Inventory, ledger accounting, AE1, AE2, AE5, and report ownership remain unchanged.
Root cause
Artifact integrity reused decoded cache content without honoring the authoritative raw-byte
content_kind, so an opaque PNG could be treated as text for mixed-script and instruction checks.Diff Notes
BINARYandOPAQUErows.Scope
This PR references #413 because it fixes the AE3/AE4 slice only. It does not change AE1 policy, artifact classification, static-runner routing, scoring, report schemas, or analyzer registration.
Verification
python -m pytest tests/nodes/test_security_remediation.py tests/nodes/analyzers/test_artifact_integrity_bounds.pypasses, including opaque inventory, AE1, AE2, AE3, and AE4 preservation coverage.git diff --checkpass.Refs #413