Conversation
Signed-off-by: Rod Boev <[email protected]>
Signed-off-by: Rod Boev <[email protected]>
Signed-off-by: Rod Boev <[email protected]>
Signed-off-by: Rod Boev <[email protected]>
rng1995
left a comment
There was a problem hiding this comment.
[SkillSpector Review]\n\nApproved. The coverage threshold validates finite values in range, fails closed on absent or non-numeric coverage, uses strict less-than semantics, and composes correctly with recursive and existing exit-code behavior. Current required checks pass.
|
Powered by Codex: PR council review result. This is a triage signal, not a maintainer approval.
|
| omitted_skills=omitted_skill_count, | ||
| limitations=aggregate_limitations, | ||
| ) | ||
| if _coverage_below_threshold({"analysis_completeness": aggregate_completeness}, min_coverage): |
There was a problem hiding this comment.
Three partial skills at 95% coverage each pass --min-coverage 90 when scanned individually. With --recursive, none counts as fully complete, so this check sees 0% and returns exit 1 even though every child meets the threshold. Could we preserve handling of omitted skills while allowing partial children whose numeric coverage meets the threshold?
| output = tmp_path / "combined.json" | ||
| monkeypatch.setattr(cli, "_MULTI_SKILL_MAX_PUBLIC_RECORDS", 1) | ||
| monkeypatch.setattr( | ||
| cli.graph, "invoke", lambda *_args, **_kwargs: _bounded_recursive_result("one") |
There was a problem hiding this comment.
Could this test return coverage_percent: 100 for its scanned child? _bounded_recursive_result currently supplies only is_complete: true, so the child’s missing-coverage check already forces exit 1. The test would still pass if the aggregate check were removed; a valid passing child would make it cover omitted scope specifically.
Summary
Added
--min-coverage FLOATas an opt-in CLI gate over the existing canonical coverage percentage. A below-threshold scan exits 1 after writing its normal report.Changes
Preserved
Default behavior,
--fail-on-incomplete, risk scoring and recommendation, output schemas, ledger coverage computation, and registry-mode boundaries remain unchanged.Validation
Focused CLI tests cover threshold boundaries, recursive children and aggregate scope, invalid values, output-before-exit, missing coverage, precedence, and schema preservation. Verification completed:
112 passed,ruff checkpassed,ruff format --checkpassed, andgit diff --checkpassed.Related
Closes #389. PR #393 supplies the separate
--fail-on-incompletebehavior.