fix(analyzer): project manifest version for RP3 - #474
Conversation
Signed-off-by: Whj9283 <[email protected]>
rng1995
left a comment
There was a problem hiding this comment.
[SkillSpector Review]
Reviewed current head 11683c4e8caab9b81ddfb5d90b2f6819fb2c6a18. The project frontmatter version now flows through the existing bounded manifest parser and scalar normalization, and the RP3 regression exercises the real analysis path. I found no required code or test changes.
All hosted required checks pass. The branch is behind main, so it must be updated and revalidated before merging.
rng1995
left a comment
There was a problem hiding this comment.
[SkillSpector Review]
Re-reviewed current head 35a8dd6197aa614d5fdcdec8c4762b248a294331 after the intervening main synchronizations. The two PR-owned blobs are unchanged from the previously assessed head. The frontmatter version still flows through the bounded scalar projection before reaching RP3, and the regression exercises the real build_context path and exact RP3 result. I found no required code or test changes.
changes, lint, DCO, and docker-smoke pass; test-unit is still running and GitHub reports merge state BLOCKED. Wait for the exact-head suite and all branch-protection gates before merging.
Summary
versionfield fromSKILL.mdfrontmatter into the bounded manifestbuild_contextbefore running the RP3 analyzerBefore this change, RP3 ran successfully but could not observe
version, so values such as"*"produced no finding.Fixes #472.
Testing
PATH="$PWD/.venv/bin:$PATH" make test-unit(3979 passed, 14 skipped, 38 deselected, 4 xfailed)PATH="$PWD/.venv/bin:$PATH" make lint format-checkversion: "*"now emitsRP3