feat(providers): Support Google's Gemini via ADC and Workload Identity - #496
feat(providers): Support Google's Gemini via ADC and Workload Identity#496bytemare wants to merge 1 commit into
Conversation
Add support for `SKILLSPECTOR_PROVIDER=gemini` using Google Cloud Application Default Credentials (ADC) and the OpenAI-compatible endpoint. - Authenticate via ADC or GKE Workload Identity with `GOOGLE_CLOUD_PROJECT` - Routes global, us, eu, and regional endpoints - Apply `google/` model prefix while keeping bare registry keys - Includes unit and live provider test targets - Fails without OpenAI fallback Signed-off-by: bytemare <[email protected]>
4e5c9c3 to
2f4dd79
Compare
rng1995
left a comment
There was a problem hiding this comment.
[SkillSpector Review]
Approved at head 2f4dd7927ceb3b018943fb6606e1a7563d70c743.
The ADC/Workload Identity provider is integrated consistently with the provider abstraction, validates project/location before URL construction, refreshes cached credentials under a lock, supports current global/multi-region/regional OpenAI-compatible endpoints, forwards quota-project metadata, and has substantive unit and live-provider coverage. Required CI is green.
This functionally supersedes open PR #12 and overlaps its provider registration, dependency, documentation, and test files; the two implementations should not both merge. Merge gate for this PR: it is mergeable but BEHIND, so update it to the protected branch's required head state first.
|
@bytemare - Please resolve merge conflicts |
Adds
SKILLSPECTOR_PROVIDER=geminito support Gemini models on Google Cloud via ADC and GKE Workload Identity, resolving #494.This supersedes stale PR #12 with Google's current v1 OpenAI-compatible endpoint (
aiplatform.googleapis.com/v1/.../endpoints/openapi), updated model metadata (gemini-3.x), and full test coverage.google-authwith ADC / Workload Identity. RequiresGOOGLE_CLOUD_PROJECTand fails if unset (no silent OpenAI fallback)google/prefix strictly with HTTP. The model registry keys, overrides, and CLI parameters stay as isglobal(default),us,eu, and regional endpoints (e.g.us-central1), with docs on data residencyx-goog-user-projectonly when explicitly configured on ADC credentials, preserving standard billing attribution without imposingserviceusage.services.userequirements on Workload Identity service accountsCloses #494