fix: avoid false parser limits and reference accounting failures - #507
Merged
Conversation
Deduplicate coverage findings for the same source line and target, and record one terminal event per source line with every emitted finding ID. This prevents Markdown label/destination duplicates and distinct targets on one line from generating fatal unaccounted_work errors. Prepared by Codex for Mohit Gupta. Signed-off-by: Mohit Gupta <[email protected]>
Distinguish simple runtime parameters from command substitutions and complex parameter expansions in the bounded printf recognizer. Count literal characters separately from already-consumed quoted spans so long prose can finish parsing without a spurious span-limit exception. Cover inline variables, skill invocations, PowerShell member access, math notation, long quoted prose, and preserved destructive-command detection and incomplete reconstruction accounting. Prepared by Codex for Mohit Gupta. Signed-off-by: Mohit Gupta <[email protected]>
Signed-off-by: yashrajbasav <[email protected]>
longchen-nv
approved these changes
Sep 9, 2026
longchen-nv
left a comment
There was a problem hiding this comment.
LGTM. Let us submit this change to unblock users.
Member
Author
|
@longchen-nv we should check this too #510 |
…nting fix: preserve partial coverage for runtime printf paths
Refresh PR #507 after merging #508 into its source branch. No source files changed. Prepared by Codex for Mohit Gupta. Signed-off-by: Mohit Gupta <[email protected]>
pull Bot
pushed a commit
to y1024/SkillSpector
that referenced
this pull request
Sep 9, 2026
Package the merged parser and reference-accounting fixes from NVIDIA#507 and the runtime executable-path coverage guard from NVIDIA#508. Update version metadata, changelog, and release notes. Prepared by Codex for Mohit Gupta. Signed-off-by: Mohit Gupta <[email protected]>
1 task
SanHsien
added a commit
to SanHsien/SkillSpector
that referenced
this pull request
Sep 11, 2026
…VIDIA#524 Raise reviewed_pr_through to 527 and reviewed_issue_through to 524 in tools/upstream_baseline.json (commit axis unchanged at 69dcdfb). Every item gets a verdict in docs/DECISIONS.md: NVIDIA#493/NVIDIA#507/NVIDIA#508/NVIDIA#511 verified via git merge-base --is-ancestor as already included through the 2.11.1/2.11.2 sync (including NVIDIA#521, which merged only into the still- open NVIDIA#516 stack, not main); the remaining 27 items stay "wait for upstream merge", none adopted now. Two items get dedicated comparison notes per docs/DIVERGENCE.md's static_runner.py and scripts/compare_scan_accuracy.py rows: NVIDIA#522 uses a different env var name and different default/semantics than this fork's SKILLSPECTOR_MAX_STATIC_SECONDS, so merging it cannot simply delete the divergence row and needs a downstream env var migration first; NVIDIA#490 extends this fork's own upstream PR NVIDIA#486 with a Python 3.14/POSIX edge case the fork's Windows environment does not hit, so NVIDIA#486 is left untouched pending upstream's own resolution. NVIDIA#501-NVIDIA#505 and NVIDIA#518 are also flagged as near-verbatim matches to this fork's existing Windows test divergence rows, worth revisiting for row deletion once merged. Co-Authored-By: Claude Opus 5 <[email protected]> Signed-off-by: SanHsien <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ordinary skill documentation can trigger false
static_parse_limitwarnings and fatal reference-accounting errors, producing CLI exit code 2. This PR fixes those failures while preserving partial coverage for commands that cannot be reconstructed safely.$ARGUMENTS, skill invocation syntax, and PowerShell member access no longer produce false parser-limit errors.unaccounted_workerrors.printf,env,command, andbuiltinexecutable paths. A familiar basename does not make a runtime-selected executable deterministic.Includes #508, merged into this PR's source branch as
f5bb619. Fixes #464.Validation:
ruff check src testsandruff format --check src testspassed after the merge.--no-llm: all had successful scanner execution and no fatal accounting errors. Some retained blocking findings. This corpus replay predates fix: preserve partial coverage for runtime printf paths #508 and is not claimed as a fresh combined-corpus or full LLM/CI rerun.Unresolved references and other analysis limitations remain visible. Downstream validation with LLM analyzers must be rerun after release adoption.
Prepared and updated by Codex on behalf of Mohit Gupta. The runtime-path follow-up in #508 was contributed by Yashraj.