Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: avoid false parser limits and reference accounting failures - #507

Merged
mohgupta-ship-it merged 5 commits into
mainfrom
codex/fix-ci-reference-completeness
Sep 9, 2026
Merged

fix: avoid false parser limits and reference accounting failures#507
mohgupta-ship-it merged 5 commits into
mainfrom
codex/fix-ci-reference-completeness

Conversation

@mohgupta-ship-it

@mohgupta-ship-it mohgupta-ship-it commented Sep 9, 2026

Copy link
Copy Markdown
Member

Ordinary skill documentation can trigger false static_parse_limit warnings and fatal reference-accounting errors, producing CLI exit code 2. This PR fixes those failures while preserving partial coverage for commands that cannot be reconstructed safely.

  • Distinguish simple runtime parameters from command substitutions and complex expansions. Inline $ARGUMENTS, skill invocation syntax, and PowerShell member access no longer produce false parser-limit errors.
  • Count directly scanned literal characters separately from already-consumed quoted spans, so long quoted documentation does not exhaust the wrong parser budget.
  • Deduplicate coverage findings by source file, line, and target, and emit one completion event per source line containing all finding IDs. Markdown label/destination duplicates and distinct targets on one line no longer cause fatal unaccounted_work errors.
  • Preserve partial coverage for runtime-selected printf, env, command, and builtin executable paths. A familiar basename does not make a runtime-selected executable deterministic.

Includes #508, merged into this PR's source branch as f5bb619. Fixes #464.

Validation:

Unresolved references and other analysis limitations remain visible. Downstream validation with LLM analyzers must be rerun after release adoption.

Prepared and updated by Codex on behalf of Mohit Gupta. The runtime-path follow-up in #508 was contributed by Yashraj.

Deduplicate coverage findings for the same source line and target, and
record one terminal event per source line with every emitted finding ID.
This prevents Markdown label/destination duplicates and distinct targets
on one line from generating fatal unaccounted_work errors.

Prepared by Codex for Mohit Gupta.

Signed-off-by: Mohit Gupta <[email protected]>
Distinguish simple runtime parameters from command substitutions and
complex parameter expansions in the bounded printf recognizer. Count
literal characters separately from already-consumed quoted spans so long
prose can finish parsing without a spurious span-limit exception.

Cover inline variables, skill invocations, PowerShell member access,
math notation, long quoted prose, and preserved destructive-command
detection and incomplete reconstruction accounting.

Prepared by Codex for Mohit Gupta.

Signed-off-by: Mohit Gupta <[email protected]>
@mohgupta-ship-it mohgupta-ship-it changed the title fix: prevent duplicate reference coverage from failing scans fix: avoid false parser limits and reference accounting failures Sep 9, 2026

@longchen-nv longchen-nv left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let us submit this change to unblock users.

@mohgupta-ship-it

Copy link
Copy Markdown
Member Author

@longchen-nv we should check this too #510

…nting

fix: preserve partial coverage for runtime printf paths
Refresh PR #507 after merging #508 into its source branch. No source files changed.

Prepared by Codex for Mohit Gupta.

Signed-off-by: Mohit Gupta <[email protected]>
@mohgupta-ship-it
mohgupta-ship-it merged commit a7dfab7 into main Sep 9, 2026
5 checks passed
@mohgupta-ship-it
mohgupta-ship-it deleted the codex/fix-ci-reference-completeness branch September 9, 2026 19:08
pull Bot pushed a commit to y1024/SkillSpector that referenced this pull request Sep 9, 2026
Package the merged parser and reference-accounting fixes from NVIDIA#507 and the runtime executable-path coverage guard from NVIDIA#508. Update version metadata, changelog, and release notes.

Prepared by Codex for Mohit Gupta.

Signed-off-by: Mohit Gupta <[email protected]>
SanHsien added a commit to SanHsien/SkillSpector that referenced this pull request Sep 11, 2026
…VIDIA#524

Raise reviewed_pr_through to 527 and reviewed_issue_through to 524 in
tools/upstream_baseline.json (commit axis unchanged at 69dcdfb). Every
item gets a verdict in docs/DECISIONS.md: NVIDIA#493/NVIDIA#507/NVIDIA#508/NVIDIA#511 verified
via git merge-base --is-ancestor as already included through the
2.11.1/2.11.2 sync (including NVIDIA#521, which merged only into the still-
open NVIDIA#516 stack, not main); the remaining 27 items stay "wait for
upstream merge", none adopted now.

Two items get dedicated comparison notes per docs/DIVERGENCE.md's
static_runner.py and scripts/compare_scan_accuracy.py rows: NVIDIA#522 uses a
different env var name and different default/semantics than this
fork's SKILLSPECTOR_MAX_STATIC_SECONDS, so merging it cannot simply
delete the divergence row and needs a downstream env var migration
first; NVIDIA#490 extends this fork's own upstream PR NVIDIA#486 with a Python
3.14/POSIX edge case the fork's Windows environment does not hit, so
NVIDIA#486 is left untouched pending upstream's own resolution. NVIDIA#501-NVIDIA#505 and
NVIDIA#518 are also flagged as near-verbatim matches to this fork's existing
Windows test divergence rows, worth revisiting for row deletion once
merged.

Co-Authored-By: Claude Opus 5 <[email protected]>
Signed-off-by: SanHsien <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

False positive error with backtick variables like $ARGUMENTS

3 participants