fix(references): reject quoted version numbers as file references - #525
Open
goodhee wants to merge 1 commit into
Open
fix(references): reject quoted version numbers as file references#525goodhee wants to merge 1 commit into
goodhee wants to merge 1 commit into
Conversation
metadata.version values like "1.2" matched the quoted/code-span path
pattern (name="1", ext="2"), so a version-only metadata field made an
otherwise clean scan report is_complete=false and raised the
recommendation from SAFE to CAUTION. Reject candidates whose
extension is purely numeric ("1.2", "v1.2", "1.2.0-beta.1"), since
real file extensions are never all digits.
This is the same class of ambiguity as NVIDIA#451 for NVIDIA#450: a bare version
number is indistinguishable from a root-level file name without
another path signal, so this only narrows the existing quoted/code
path pattern rather than trying to fully disambiguate intent.
Fixes NVIDIA#524.
Signed-off-by: goodhee <[email protected]>
goodhee
force-pushed
the
fix/524-quoted-version-metadata-reference
branch
from
September 11, 2026 01:52
f785d45 to
1f2739f
Compare
rng1995
requested changes
Sep 12, 2026
rng1995
left a comment
Collaborator
There was a problem hiding this comment.
[SkillSpector Review]
Reviewed head 1f2739f1fbe004fa10a3a8a809609f25473a646c — REQUEST_CHANGES.
src/skillspector/references.py:137: the numeric-suffix heuristic rejects real paths, including paths with an explicit directory signal such asdocs/tool.1. Numeric extensions are valid (manual pages and numbered artifacts are common), and this rejection happens before the resolver can checkknown_paths, so a shipped, explicitly referenced file becomes invisible to reference coverage. Apply the version heuristic only to genuinely ambiguous metadata tokens, or first preserve candidates that resolve to a known bundled path. Add a regression for a knowndocs/tool.1reference.
Required checks pass, but the correctness regression and mergeStateStatus=BEHIND block merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
numeric (e.g. "1.2", "v1.2", "1.2.0-beta.1")
Before this change,
metadata.version: "1.2"in SKILL.md frontmatter matchedthe quoted-path pattern (name="1", ext="2") and was treated as a missing
local file reference, flipping an otherwise clean scan from
SAFE/is_complete: truetoCAUTION/is_complete: false.Fixes #524.
Testing
uv run pytest tests/nodes/test_security_remediation.py -q(310 passed)uv run ruff check src/ tests/uv run ruff format --check src/ tests/