[Transformer] Manipulate NCCL_NET for hybrid IB/Socket setups#1620
Merged
Conversation
crcrpar
reviewed
Mar 17, 2023
crcrpar
reviewed
Apr 14, 2023
crcrpar
reviewed
Apr 18, 2023
crcrpar
approved these changes
Apr 18, 2023
yuanzhedong
pushed a commit
to yuanzhedong/apex
that referenced
this pull request
Jul 14, 2023
…#1620) * set NCCL Socket for p2p * clean up * refactor parallel_state.py * update parallel_state * fix minor bug * fix minor bug 2 * Update parallel_state.py * introduce NET_BLOCK_SIZE * fix small bug * Better cross-block check * some cleanups * more cleanups * more cleanups * more cleanup * swap lines * update else * minor fix * default to NCCL * apply suggestions and add more description * revert one line change * move default_nccl_net down * forgot one line * remove unnecessary spaces * apply nit-picking * raise RuntimeError if NCCL_SOCKET_IFNAME missing * Revert HAS_UCC * Add missing space
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.