Thanks to visit codestin.com
Credit goes to github.com

Skip to content

build extensions in parallel #1882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
crcrpar merged 4 commits into from
Feb 25, 2025
Merged

build extensions in parallel #1882

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f0df092
build extensions in parallel
yuantailing Feb 20, 2025
d9c3507
fix: setup.py develop supports --parallel
yuantailing Feb 21, 2025
f1ee5b1
update README.md
yuantailing Feb 21, 2025
fd28caf
Update README.md: Remove an `export` command
yuantailing Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: setup.py develop supports --parallel
  • Loading branch information
@yuantailing
yuantailing committed Feb 21, 2025
commit d9c3507ae087ddf7549383f6cd4e3b8955758adb
9 changes: 7 additions & 2 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -860,7 +860,7 @@ def check_cudnn_version_and_warn(global_option: str, required_cudnn_version: int
)


# Patch because `setup.py bdist_wheel` does not accept the `parallel` option
# Patch because `setup.py bdist_wheel` and `setup.py develop` do not support the `parallel` option
parallel = None
if "--parallel" in sys.argv:
idx = sys.argv.index("--parallel")
Expand All @@ -874,6 +874,11 @@ class BuildExtensionSeparateDir(BuildExtension):
build_extension_patch_lock = threading.Lock()
thread_ext_name_map = {}

def finalize_options(self):
if parallel is not None:
self.parallel = parallel
super().finalize_options()

def build_extension(self, ext):
with self.build_extension_patch_lock:
if not getattr(self.compiler, "_compile_separate_output_dir", False):
Expand Down Expand Up @@ -902,6 +907,6 @@ def compile_new(*args, **kwargs):
install_requires=["packaging>20.6"],
description="PyTorch Extensions written by NVIDIA",
ext_modules=ext_modules,
cmdclass={"build_ext": BuildExtensionSeparateDir.with_options(parallel=parallel)} if ext_modules else {},
cmdclass={"build_ext": BuildExtensionSeparateDir} if ext_modules else {},
extras_require=extras,
)