Remove version dependent macros & extension specific arch flags except fmha#1918
Merged
Conversation
nWEIdia
reviewed
Jul 16, 2025
Collaborator
nWEIdia
left a comment
There was a problem hiding this comment.
If a user is not providing TORCH_CUDA_ARCH_LIST, what is the default that is being used?
Collaborator
Author
|
I think it'd be the arch of the visible cuda devices as they are pytorch cuda extensions |
Aidyn-A
approved these changes
Aug 3, 2025
Collaborator
Aidyn-A
left a comment
There was a problem hiding this comment.
Well, I really do like these changes. Less boilerplate, less headache. Thanks!
Collaborator
Author
|
Marking draft for now since some modules seem to need to be special cased |
Signed-off-by: Masaki Kozuki <[email protected]>
Signed-off-by: Masaki Kozuki <[email protected]>
Signed-off-by: Masaki Kozuki <[email protected]>
Signed-off-by: Masaki Kozuki <[email protected]>
Signed-off-by: Masaki Kozuki <[email protected]>
nWEIdia
approved these changes
Aug 20, 2025
Collaborator
nWEIdia
left a comment
There was a problem hiding this comment.
Thanks for the improvement!
This was referenced Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TORCH_CUDA_ARCH_LISTfmhalooks like a special case, still needs cc_flags