Remove compat.h#1942
Conversation
Signed-off-by: Masaki Kozuki <[email protected]>
b471905 to
5114a8c
Compare
|
@copilot could you replace |
* Initial plan * Replace remaining DATA_PTR with data_ptr Co-authored-by: crcrpar <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: crcrpar <[email protected]>
|
@copilot open a new pull request to apply changes based on the comments in this thread and #1942 (comment) |
* Initial plan * Fix spacing in ternary operators in csrc/welford.cu Co-authored-by: crcrpar <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: crcrpar <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 20 out of 21 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| mean.data_ptr<accscalar_t>(), | ||
| inv_std.data_ptr<accscalar_t>(), | ||
| weight.has_value() ? weight.value().data_ptr<accscalar_t>() : NULL, | ||
| shift.has_value() ? shift.value().data_ptr<accscalar_t>() : NULL, |
There was a problem hiding this comment.
Missing space before NULL after the ternary operator colon. For consistency with the rest of the codebase, there should be a space: : NULL instead of :NULL.
| mean.data_ptr<accscalar_t>(), | ||
| inv_std.data_ptr<accscalar_t>(), | ||
| weight.has_value() ? weight.value().data_ptr<scalar_t_0>() : NULL, | ||
| shift.has_value() ? shift.value().data_ptr<scalar_t_0>() : NULL, |
There was a problem hiding this comment.
Missing space before NULL after the ternary operator colon. For consistency with the rest of the codebase, there should be a space: : NULL instead of :NULL.
|
@copilot open a new pull request to apply changes based on the comments in this thread |
As per title, this PR removes
compat.hand replacesDATA_PTRwithdata_ptr.