[pre-commit.ci] pre-commit autoupdate#1966
Merged
Merged
Conversation
updates: - [github.com/pre-commit/mirrors-clang-format: v17.0.6 → v21.1.6](pre-commit/mirrors-clang-format@v17.0.6...v21.1.6) - [github.com/astral-sh/ruff-pre-commit: v0.14.0 → v0.14.7](astral-sh/ruff-pre-commit@v0.14.0...v0.14.7)
for more information, see https://pre-commit.ci
Contributor
There was a problem hiding this comment.
Pull request overview
This PR is a pre-commit autoupdate that updates two tools:
- clang-format from v17.0.6 to v21.1.6
- ruff from v0.14.0 to v0.14.7
The changes are purely stylistic code formatting updates applied automatically by the updated clang-format tool. All modifications are cosmetic C/C++ pointer and reference syntax changes with no functional impact.
Key Changes:
- Pointer syntax:
T *x→T* x(asterisk attached to type) - Reference syntax:
T &x→T& x(ampersand attached to type) - Cast syntax:
(void *)→(void*)(no space before closing parenthesis) - Operator spacing:
numSM* numBlocksPerSm→numSM * numBlocksPerSm(proper spacing around multiplication) - Macro formatting: multi-line macros properly aligned
Reviewed changes
Copilot reviewed 19 out of 89 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| csrc/type_shim.h | Pointer syntax updates in function signatures and comments |
| csrc/multi_tensor_adagrad.cu | Pointer and cast syntax formatting |
| csrc/megatron/*.h | Extensive pointer/reference syntax updates in CUDA kernels |
| csrc/megatron/*.cpp | Const reference parameter formatting |
| csrc/megatron/*.cu | Pointer/cast syntax and operator spacing fixes |
| csrc/fused_dense*.cu/.cpp | Pointer and cast formatting in function declarations |
| apex/contrib/sparsity/*.cu | Macro formatting and operator spacing |
| apex/contrib/csrc/xentropy/*.cu/.cpp | Pointer/reference syntax in templates and functions |
| apex/contrib/csrc/transducer/*.cu | Pointer syntax in device functions |
| apex/contrib/csrc/peer_memory/*.cu | Operator spacing fix |
| apex/contrib/csrc/nccl_allocator/*.cpp | Pointer syntax in function signatures |
| apex/contrib/csrc/multihead_attn/.cuh/.cu/*.cpp | Extensive pointer/reference/cast formatting |
| apex/contrib/csrc/layer_norm/.h/.cuh/*.cu | Pointer/reference syntax and operator spacing |
| apex/contrib/csrc/group_norm_v2/*.hpp | Const reference syntax |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updates: