Remove tests and examples for deprecated apex.contrib.fmha and apex.contrib.multihead_attn#1995
Conversation
There was a problem hiding this comment.
Pull request overview
This PR follows up on #1932 by removing now-obsolete test coverage and standalone example scripts for the deprecated apex.contrib.fmha and apex.contrib.multihead_attn components.
Changes:
- Deleted
apex.contrib.multihead_attnunit tests underapex/contrib/test/multihead_attn/. - Deleted
apex.contrib.fmhaunit tests underapex/contrib/test/fmha/. - Removed standalone multihead-attention example scripts under
apex/contrib/examples/multihead_attn/.
Reviewed changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| apex/contrib/test/multihead_attn/test_self_multihead_attn_norm_add.py | Removes deprecated self-attention norm+add test. |
| apex/contrib/test/multihead_attn/test_self_multihead_attn.py | Removes deprecated self-attention tests (basic + masking variants). |
| apex/contrib/test/multihead_attn/test_mha_fused_softmax.py | Removes deprecated fused softmax/dropout test. |
| apex/contrib/test/multihead_attn/test_fast_self_multihead_attn_bias.py | Removes deprecated fast self-attention additive mask/bias test. |
| apex/contrib/test/multihead_attn/test_encdec_multihead_attn_norm_add.py | Removes deprecated enc/dec norm+add test. |
| apex/contrib/test/multihead_attn/test_encdec_multihead_attn.py | Removes deprecated enc/dec tests (basic + masking variants). |
| apex/contrib/test/fmha/test_fmha.py | Removes deprecated FMHA forward/backward correctness tests. |
| apex/contrib/examples/multihead_attn/perf_test_multihead_attn.py | Removes deprecated performance benchmarking script. |
| apex/contrib/examples/multihead_attn/func_test_multihead_attn.py | Removes deprecated functional comparison script. |
Comments suppressed due to low confidence (1)
apex/contrib/examples/multihead_attn/perf_test_multihead_attn.py:1
- Removing this example script leaves stale references in
apex/contrib/multihead_attn/README.md(it instructs users to runcontrib/examples/multihead_attn/perf_test_multihead_attn.py). Please update or remove that documentation (or relocate the script) so the README doesn’t point to a non-existent path.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
ideally https://github.com/Aidyn-A/apex/tree/remove_controb_mha_tests/apex/contrib/multihead_attn#try-performance-tests-yourself should also get updated as
|
Per title. This PR removes tests and examples as a follow up to #1932.