Seryilmaz/fused dropout softmax#985
Merged
Merged
Conversation
set random offset fix typos in softmax.h write softmax results, needed for dgrad fix typo typos typo typo set types remove some includes remove nullpyt, use reinterpret cast data type instead of pointer for data_ptr template argument fix pointer increments in vector copies changes for recomputing softmax in dgrad typo fixes for recomputing softmax in dgrad change backward function in fused dropout module typo change function name typo typo typo typo don't return pad_mask in fprop function add stream fix softmax dgrad summation save more memory by removing softmax output remove softmax results from cpp file typo typo debugging print typo remove debugging stuff some vectorization optimizations vectorize both fprop and bprop typo try no vectorization remove float4 for dropout Revert "remove float4 for dropout" This reverts commit 59894b4. Revert "try no vectorization" This reverts commit b2ef02f. cleanup typo typo typo typo use null tensor for backward typo add specialization for vectorization typo typo don't use hadd2 for additive mask print args typo pull rand generation early, pipeline mask stores use half2 for loads remove prints philox from pytorch upstream actually ad philox file cleanup cleanup
kevinstephano
approved these changes
Dec 2, 2020
Contributor
kevinstephano
left a comment
There was a problem hiding this comment.
This looks okay to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fuses dropout and softmax both in fprop and bprop. This is only done in additive masked case for now, used by BERT. Following changes are made: