-
Notifications
You must be signed in to change notification settings - Fork 208
Closed
Labels
P1Medium priority - Should doMedium priority - Should doenhancementAny code-related improvementsAny code-related improvements
Description
I think this is a defect likely in the codegen:
File "/home/leof/dev/cuda_py/cuda/py/compiler.py", line 20, in __init__
nvrtc.nvrtcCreateProgram(code.encode(), b"default", 0, (), ()))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: Argument 'headers' has incorrect type (expected list, got tuple)
which hard-codes the argument types to be a list:
Line 203 in b88592a
def nvrtcCreateProgram(char* src, char* name, int numHeaders, list headers, list includeNames): |
We should do some housekeeping and check other such instances. We don't need to unnecessarily constrain the type of an iterable unless there's a good reason.
Metadata
Metadata
Assignees
Labels
P1Medium priority - Should doMedium priority - Should doenhancementAny code-related improvementsAny code-related improvements