-
Notifications
You must be signed in to change notification settings - Fork 207
Add support for cuDSS lib #931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Putting in draft until I test it on Windows (shortly) |
Could you please also change cuda_pathfinder/cuda/pathfinder/_version.py Change to
so that we don't have misleading versioning? I'll also need to update docs/source/release, I will do that in a separate PR. |
/ok to test |
…-cu12` in pyproject.toml
/ok to test 554ebc7 |
This comment has been minimized.
This comment has been minimized.
For easy reference: All tests passed at commit 554ebc7 https://github.com/NVIDIA/cuda-python/actions/runs/17334713680?pr=931 |
To ensure our testing covers https://github.com/NVIDIA/cuda-python/actions/runs/17334713680?pr=931 Download log archive:
|
Additional manual testing with conda:
|
/ok to test bc73539 |
@leofang I decided it's most efficient to pack the Assuming the tests pass (seems extremely likely because there are no code changes compared to the previous pass), and with your approval, I could easily release this still today; it could be really quick. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, but still wait for @leofang final approval before merging.
This is a most bizarre error: https://github.com/NVIDIA/cuda-python/actions/runs/17335731665/job/49221850858?pr=931
|
I'm rerunning the one failed job, in hopes that it was something weird on that particular runner. |
|
Yes I've seen that too. It's due to network glitches. We want to use new enough
https://github.com/NVIDIA/cuda-python/actions/runs/17335731665/job/49221850858?pr=931#step:12:79 |
Description
Bump pathfinder version to 1.2.1 (for release)
Relevant links: