fix(cli): build approval for mcp-app#118
Open
coryrylan wants to merge 1 commit into
Open
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughRebrands the MCP server name, whitelists an MCP extension in pnpm workspace builds, and centralizes/simplifies starter NPM install failure handling with a new message helper and tests. ChangesMCP App Starter Configuration and Installation Updates
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@projects/internals/tools/src/project/starters.ts`:
- Around line 276-279: The manual-install hint currently interpolates a null
npmClient when getNPMClient() returns null; in installFromRegistry() (or the
caller handling the catch) check the returned npmClient before printing the hint
and print a safe fallback message when null (e.g., instruct the user to run a
package-manager install in the extractedDir or suggest installing npm/pnpm),
otherwise print the existing `${npmClient} install` message; reference the
variables/functions npmClient, getNPMClient, installFromRegistry, and
extractedDir to locate and update the error-handling branch.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: ad8e0ac7-92eb-4db5-8eb6-2b5bd4afbe58
📒 Files selected for processing (3)
projects/cli/src/mcp/mcp.tsprojects/internals/tools/src/project/starters.tsprojects/starters/mcp-app/pnpm-workspace.yaml
johnyanarella
approved these changes
Jun 4, 2026
Signed-off-by: Cory Rylan <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Bug Fixes
Chores