Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(logging): prevent log file race condition under parallel attempts #1827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nuthalapativarun wants to merge 4 commits into
base: main
Choose a base branch
from
+428 −1
Open

fix(logging): prevent log file race condition under parallel attempts #1827

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f40ba3f
fix(logging): prevent log file race condition under parallel attempts
nuthalapativarun Jun 2, 2026
727728b
test(logging): add unit and integration tests for _worker_logging_init
nuthalapativarun Jun 5, 2026
7aa5f86
test(probes): add regression test demonstrating parallel logging init…
nuthalapativarun Jun 11, 2026
76d0003
test: add regression test demonstrating worker fd isolation for log r…
nuthalapativarun Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 32 additions & 1 deletion garak/probes/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,37 @@
import garak.resources.theme


def _worker_logging_init():
"""Pool initializer: close inherited log file handles and re-configure logging.

When :mod:`multiprocessing` spawns or forks worker processes the parent's
open :class:`logging.FileHandler` file descriptors are inherited. Concurrent
writes through those shared handles can trigger a reentrant-flush
``RuntimeError`` (see GitHub issue #1355). This initializer runs once inside
each worker, closes every inherited handler, and re-applies the same
``basicConfig`` the main process used, so each worker gets its own private
file descriptor pointing at the same log file.
"""
import os
import logging

root = logging.getLogger()
for handler in root.handlers[:]:
try:
handler.close()
except Exception:
pass
root.removeHandler(handler)

log_filename = os.environ.get("GARAK_LOG_FILE")
if log_filename:
logging.basicConfig(
filename=log_filename,
level=logging.DEBUG,
format="%(asctime)s %(levelname)s %(message)s",
)


class Probe(Configurable):
"""Base class for objects that define and execute LLM evaluations"""

Expand Down Expand Up @@ -332,7 +363,7 @@ def _execute_all(self, attempts) -> Iterable[garak.attempt.Attempt]:

attempt_pool = None
try:
attempt_pool = Pool(pool_size)
attempt_pool = Pool(pool_size, initializer=_worker_logging_init)
for result in attempt_pool.imap_unordered(
self._execute_attempt, attempts
):
Expand Down
Loading