Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@itspooya
Copy link
Contributor

@copy-pr-bot
Copy link

copy-pr-bot bot commented Feb 26, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@itspooya
Copy link
Contributor Author

Hello Dear @tariq1890
I wanted to ask you if you could review these changes and possibly point out any changes I need to do?
Thank you

@tariq1890
Copy link
Contributor

Thank you for your contribution @itspooya! I think this change makes sense. I'll let @cdesiniotis and/or @shivamerla chime in as well.

This blogpost provides a useful summary of why this change is beneficial

Copy link
Contributor

@cdesiniotis cdesiniotis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cdesiniotis
Copy link
Contributor

/ok to test

@tariq1890
Copy link
Contributor

@itspooya Can you rebase your PR?

@tariq1890
Copy link
Contributor

/ok-to-test

@tariq1890 tariq1890 enabled auto-merge March 13, 2025 16:54
@tariq1890
Copy link
Contributor

Hi @itspooya , it looks like the PR is failing. Can you run go mod tidy && go mod vendor and check in those changes? Let's squash the commit history as well

@tariq1890 tariq1890 disabled auto-merge March 13, 2025 17:40
@cdesiniotis
Copy link
Contributor

I have opened #1344 to resolve the CI failures and to squash the commit history.

@tariq1890
Copy link
Contributor

Hi @itspooya , Chris has committed these changes with you as the Co-Author. Your contribution to gpu-operator is much appreciated! Thank you!

Closing the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants