test(benchmark): pin tachometer full-endpoint coverage for agentperf - #357
Open
nv-yna wants to merge 1 commit into
Open
test(benchmark): pin tachometer full-endpoint coverage for agentperf#357nv-yna wants to merge 1 commit into
nv-yna wants to merge 1 commit into
Conversation
The agentperf client never polls /metrics, so the client-polled set must stay empty and Tachometer's complement must be the full endpoint set. Today that falls out of AgentPerfRunner not inheriting AIPerfBenchmarkRunner; these tests make the contract explicit so a reparent or a stray AIPERF_SERVER_METRICS_URLS injection fails loudly instead of silently dropping worker metrics from observability runs. Signed-off-by: Yuewei Na <[email protected]>
nv-yna
requested review from
alec-flowers,
csahithi,
ishandhanani and
nlevin-ui
as code owners
August 27, 2026 20:53
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #357 +/- ##
=======================================
Coverage ? 72.28%
=======================================
Files ? 96
Lines ? 13230
Branches ? 0
=======================================
Hits ? 9563
Misses ? 3667
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to #350/#353. Two tests pinning the contract that the
agentperfbenchmark type's client-polled metrics set is empty, so Tachometer's complement underobservability.enabledis the full endpoint set.Why
Today the behavior falls out of
AgentPerfRunnernot inheritingAIPerfBenchmarkRunner— nothing fails if someone reparents the runner or starts injectingAIPERF_SERVER_METRICS_URLSfor it. Either change would silently drop worker endpoints from observability captures while no client actually polls them (the agentperf client never scrapes/metrics).make check: 1493 passed.🤖 Generated with Claude Code