fix(sweep): filter invalid vLLM GPU topologies - #375
Open
dipeshbabu wants to merge 1 commit into
Open
Conversation
Signed-off-by: Dipesh Babu <[email protected]>
dipeshbabu
requested review from
alec-flowers,
csahithi,
ishandhanani and
nlevin-ui
as code owners
September 3, 2026 00:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Cartesian topology sweeps in
srt-slurm-recipescurrently expand combinations such as TP8/PP8/DP8 on an eight-GPU node. Those jobs cannot run, but constraining the recipes to TP8/PP1 also removes useful coverage such as TP4/DP2.This addresses the root cause requested in NVIDIA/srt-slurm-recipes#9 by filtering incompatible vLLM variants during sweep generation.
Validation
pytest tests/ -qon Linux: 1551 passed, 2 skipped, 6 deselectedpytest tests/test_sweep.py -qon Linux and Windows: 25 passedruff check src/srtctl/ruff format --check src/srtctl/ty check src/srtctl/core/sweep.pyChecklist