feat(postprocess): exclude AIPerf inputs.json from uploaded artifacts. - #383
Open
fsaady wants to merge 5 commits into
Open
feat(postprocess): exclude AIPerf inputs.json from uploaded artifacts.#383fsaady wants to merge 5 commits into
fsaady wants to merge 5 commits into
Conversation
Signed-off-by: Fadi Saady <[email protected]>
…json-artifact Signed-off-by: Fadi Saady <[email protected]>
fsaady
requested review from
alec-flowers,
csahithi,
ishandhanani and
nlevin-ui
as code owners
September 4, 2026 12:41
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #383 +/- ##
=======================================
Coverage ? 73.83%
=======================================
Files ? 101
Lines ? 14146
Branches ? 0
=======================================
Hits ? 10445
Misses ? 3701
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Signed-off-by: Fadi Saady <[email protected]>
fsaady
commented
Sep 4, 2026
| quarantined_path: Path | ||
|
|
||
|
|
||
| _AIPERF_ARTIFACT_EXCLUSIONS = (_ArtifactExclusion(pattern="artifacts/**/inputs.json"),) |
Author
There was a problem hiding this comment.
This only works because I was using --artifact-dir in the aiperf command. Making it more generic now
Author
There was a problem hiding this comment.
Changed it to **/inputs.json.
Reviewers: what do you think?
…ts.json from aiperf artifacts. Signed-off-by: Fadi Saady <[email protected]>
- Easier to add new exclusions for other runners. Signed-off-by: Fadi Saady <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature Summary:
Exclude AIPerf-generated inputs.json files from saved artifacts. During postprocessing, srt-slurm temporarily moves these files outside the log directory so artifact rollup and upload ignore them, then restores them afterward. This applies to all benchmarks using
AIPerfBenchmarkRunner.Reasoning:
AIPerf now generates inputs.json, which can be large and is not useful as a persisted benchmark artifact. Keeping it increases archive size and upload/storage costs unnecessarily. Temporarily quarantining it avoids publishing the file while preserving the local output and leaving benchmark runners independent of artifact-handling concerns.