Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(profiling): expose common nsys flags - #412

Open
zbpatel wants to merge 1 commit into
NVIDIA:mainfrom
zbpatel:codex/configurable-nsys-flags
Open

feat(profiling): expose common nsys flags#412
zbpatel wants to merge 1 commit into
NVIDIA:mainfrom
zbpatel:codex/configurable-nsys-flags

Conversation

@zbpatel

@zbpatel zbpatel commented Sep 9, 2026

Copy link
Copy Markdown

Summary

  • expose trace_domain, cuda_graph_trace_mode, and sample_mode in the profiling recipe
  • apply explicit overrides consistently to TRT-LLM and non-TRT-LLM nsys commands
  • preserve every existing backend-specific default when the new keys are omitted
  • document the settings and cover both time- and iteration-based paths

Testing

  • uv run ruff check src/srtctl/core/schema.py tests/test_profiling.py
  • uv run pytest tests/test_profiling.py -v --tb=short (34 passed)
  • git diff --check

A full-suite run reached unrelated existing failures: test_apply_mock_emits_submission_json_and_spawns_worker has no effective CPU allocation on this host, and the SA-Bench script tests cannot locate profiling.sh when sourced from the test harness.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@e60c64a). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #412   +/-   ##
=======================================
  Coverage        ?   73.90%           
=======================================
  Files           ?      101           
  Lines           ?    14118           
  Branches        ?        0           
=======================================
  Hits            ?    10434           
  Misses          ?     3684           
  Partials        ?        0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants