fix(tachometer): publish completed Parquet parts atomically - #427
Open
nv-yna wants to merge 2 commits into
Open
Conversation
Signed-off-by: Yuewei Na <[email protected]>
Signed-off-by: Yuewei Na <[email protected]>
nv-yna
requested review from
alec-flowers,
csahithi,
ishandhanani and
nlevin-ui
as code owners
September 12, 2026 20:25
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #427 +/- ##
=======================================
Coverage ? 75.25%
=======================================
Files ? 109
Lines ? 16115
Branches ? 0
=======================================
Hits ? 12127
Misses ? 3988
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Sep 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Periodic compaction can discover an
out-N.parquetfile before its writer closes the Parquet footer. It then classifies the open file as invalid and deletes it; the writer can still finish through its open file descriptor, report success, and clear the buffered rows.Write each raw part to a unique temporary file in the same directory and publish its final name only after the Parquet writer closes successfully. Temporary output is removed on write, close, or rename errors. Reuse the already-locked
tempfiledependency by moving it from dev dependencies. Existing schemas and published-file compaction policy are unchanged.Validation:
compactor deleted the unfinished write; the fix preserves every row exactly once across successive compactions.rustfmt --checkandgit diff --checkpassed. Required all-file pre-commit exposed 39 remaining pre-existing Python findings and reformatted 10 unrelated files; those edits were preserved in the validation record and reverted. Scoped hooks have no applicable files. Formatting is a separate signed commit.Related: #428 fixes the independent Slurm SIGTERM delivery issue during Tachometer shutdown.
All seven CI checks passed at commit2efcb70c9259bc863c24d6302180367ffbb48d78, including the Tachometer tests and scraper binary build.