Thanks to visit codestin.com
Credit goes to github.com

Skip to content

remove nlp/modules#14934

Merged
dimapihtar merged 48 commits into
mainfrom
dpykhtar/remove_nlp_modules
Dec 10, 2025
Merged

remove nlp/modules#14934
dimapihtar merged 48 commits into
mainfrom
dpykhtar/remove_nlp_modules

Conversation

@dimapihtar
Copy link
Copy Markdown
Collaborator

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
dimapihtar and others added 10 commits October 15, 2025 10:28
Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
dimapihtar and others added 12 commits October 15, 2025 12:21
Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
@dimapihtar dimapihtar marked this pull request as ready for review December 2, 2025 18:02
Comment thread nemo/collections/speechlm/utils/text_generation/audio_text_generation_utils.py Outdated
Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
Copy link
Copy Markdown
Member

@nithinraok nithinraok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM related to ASR

@github-actions github-actions Bot removed the Run CICD label Dec 9, 2025
Copy link
Copy Markdown
Collaborator

@blisc blisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine for TTS

@github-actions
Copy link
Copy Markdown
Contributor

[🤖]: Hi @dimapihtar 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully.

So it might be time to merge this PR or get some approvals.

//cc @chtruong814 @ko3n1g @pablo-garay @thomasdhc

@dimapihtar dimapihtar merged commit 0b1be8d into main Dec 10, 2025
270 of 276 checks passed
@dimapihtar dimapihtar deleted the dpykhtar/remove_nlp_modules branch December 10, 2025 23:32
chtruong814 pushed a commit that referenced this pull request Jan 4, 2026
* move tokenizer_utils

Signed-off-by: dimapihtar <[email protected]>

* remove tokenizer_utils

Signed-off-by: dimapihtar <[email protected]>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <[email protected]>

* fix style

Signed-off-by: dimapihtar <[email protected]>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <[email protected]>

* fix style

Signed-off-by: dimapihtar <[email protected]>

* remove extra import

Signed-off-by: dimapihtar <[email protected]>

* move vocab file name

Signed-off-by: dimapihtar <[email protected]>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <[email protected]>

* remove HF imports

Signed-off-by: dimapihtar <[email protected]>

* remove hyena submodule

Signed-off-by: dimapihtar <[email protected]>

* remove transformer submodule

Signed-off-by: dimapihtar <[email protected]>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <[email protected]>

* fix style

Signed-off-by: dimapihtar <[email protected]>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <[email protected]>

* remove .py files

Signed-off-by: dimapihtar <[email protected]>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <[email protected]>

* remove .py files

Signed-off-by: dimapihtar <[email protected]>

* remove .py files

Signed-off-by: dimapihtar <[email protected]>

* remove .py files

Signed-off-by: dimapihtar <[email protected]>

* fix style

Signed-off-by: dimapihtar <[email protected]>

* remove nlp.modules.megatron

Signed-off-by: dimapihtar <[email protected]>

* remove nlp collection

Signed-off-by: dimapihtar <[email protected]>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <[email protected]>

* fix style

Signed-off-by: dimapihtar <[email protected]>

* fix code style

Signed-off-by: dimapihtar <[email protected]>

* fix code style

Signed-off-by: dimapihtar <[email protected]>

* fix code style

Signed-off-by: dimapihtar <[email protected]>

* fix import

Signed-off-by: dimapihtar <[email protected]>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <[email protected]>

* fix code style

Signed-off-by: dimapihtar <[email protected]>

* fix imports

Signed-off-by: dimapihtar <[email protected]>

* fix import

Signed-off-by: dimapihtar <[email protected]>

* fix imports

Signed-off-by: dimapihtar <[email protected]>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <[email protected]>

* fix imports

Signed-off-by: dimapihtar <[email protected]>

* remove unused function

Signed-off-by: dimapihtar <[email protected]>

* fix import

Signed-off-by: dimapihtar <[email protected]>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <[email protected]>

* fix imports

Signed-off-by: dimapihtar <[email protected]>

* fix unit tests

Signed-off-by: dimapihtar <[email protected]>

* fix imports

Signed-off-by: dimapihtar <[email protected]>

* fix imports

Signed-off-by: dimapihtar <[email protected]>

* fix import

Signed-off-by: dimapihtar <[email protected]>

* fix import

Signed-off-by: dimapihtar <[email protected]>

* fix code style

Signed-off-by: dimapihtar <[email protected]>

---------

Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
Co-authored-by: dimapihtar <[email protected]>
Signed-off-by: Charlie Truong <[email protected]>
chtruong814 pushed a commit that referenced this pull request Jan 6, 2026
* move tokenizer_utils

Signed-off-by: dimapihtar <[email protected]>

* remove tokenizer_utils

Signed-off-by: dimapihtar <[email protected]>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <[email protected]>

* fix style

Signed-off-by: dimapihtar <[email protected]>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <[email protected]>

* fix style

Signed-off-by: dimapihtar <[email protected]>

* remove extra import

Signed-off-by: dimapihtar <[email protected]>

* move vocab file name

Signed-off-by: dimapihtar <[email protected]>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <[email protected]>

* remove HF imports

Signed-off-by: dimapihtar <[email protected]>

* remove hyena submodule

Signed-off-by: dimapihtar <[email protected]>

* remove transformer submodule

Signed-off-by: dimapihtar <[email protected]>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <[email protected]>

* fix style

Signed-off-by: dimapihtar <[email protected]>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <[email protected]>

* remove .py files

Signed-off-by: dimapihtar <[email protected]>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <[email protected]>

* remove .py files

Signed-off-by: dimapihtar <[email protected]>

* remove .py files

Signed-off-by: dimapihtar <[email protected]>

* remove .py files

Signed-off-by: dimapihtar <[email protected]>

* fix style

Signed-off-by: dimapihtar <[email protected]>

* remove nlp.modules.megatron

Signed-off-by: dimapihtar <[email protected]>

* remove nlp collection

Signed-off-by: dimapihtar <[email protected]>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <[email protected]>

* fix style

Signed-off-by: dimapihtar <[email protected]>

* fix code style

Signed-off-by: dimapihtar <[email protected]>

* fix code style

Signed-off-by: dimapihtar <[email protected]>

* fix code style

Signed-off-by: dimapihtar <[email protected]>

* fix import

Signed-off-by: dimapihtar <[email protected]>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <[email protected]>

* fix code style

Signed-off-by: dimapihtar <[email protected]>

* fix imports

Signed-off-by: dimapihtar <[email protected]>

* fix import

Signed-off-by: dimapihtar <[email protected]>

* fix imports

Signed-off-by: dimapihtar <[email protected]>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <[email protected]>

* fix imports

Signed-off-by: dimapihtar <[email protected]>

* remove unused function

Signed-off-by: dimapihtar <[email protected]>

* fix import

Signed-off-by: dimapihtar <[email protected]>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <[email protected]>

* fix imports

Signed-off-by: dimapihtar <[email protected]>

* fix unit tests

Signed-off-by: dimapihtar <[email protected]>

* fix imports

Signed-off-by: dimapihtar <[email protected]>

* fix imports

Signed-off-by: dimapihtar <[email protected]>

* fix import

Signed-off-by: dimapihtar <[email protected]>

* fix import

Signed-off-by: dimapihtar <[email protected]>

* fix code style

Signed-off-by: dimapihtar <[email protected]>

---------

Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
Co-authored-by: dimapihtar <[email protected]>
Signed-off-by: Charlie Truong <[email protected]>
@chtruong814 chtruong814 mentioned this pull request Jan 6, 2026
8 tasks
chtruong814 added a commit that referenced this pull request Jan 6, 2026
* remove nlp.parts collection (#14617)

* remove nlp.parts collection

Signed-off-by: dimapihtar <[email protected]>

* remove nemo legacy import

Signed-off-by: dimapihtar <[email protected]>

* remove nlp.parts collection

Signed-off-by: dimapihtar <[email protected]>

* fix style

Signed-off-by: dimapihtar <[email protected]>

* fix style

Signed-off-by: dimapihtar <[email protected]>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <[email protected]>

* move nlp_overrides

Signed-off-by: dimapihtar <[email protected]>

* fix styl

Signed-off-by: dimapihtar <[email protected]>

* remove extra scripts

Signed-off-by: dimapihtar <[email protected]>

* remove extra test

Signed-off-by: dimapihtar <[email protected]>

---------

Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
Co-authored-by: dimapihtar <[email protected]>
Signed-off-by: Charlie Truong <[email protected]>

* revert ckpt scripts removal from #14617 (#15048)

Signed-off-by: Charlie Truong <[email protected]>

* remove nlp/modules (#14934)

* move tokenizer_utils

Signed-off-by: dimapihtar <[email protected]>

* remove tokenizer_utils

Signed-off-by: dimapihtar <[email protected]>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <[email protected]>

* fix style

Signed-off-by: dimapihtar <[email protected]>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <[email protected]>

* fix style

Signed-off-by: dimapihtar <[email protected]>

* remove extra import

Signed-off-by: dimapihtar <[email protected]>

* move vocab file name

Signed-off-by: dimapihtar <[email protected]>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <[email protected]>

* remove HF imports

Signed-off-by: dimapihtar <[email protected]>

* remove hyena submodule

Signed-off-by: dimapihtar <[email protected]>

* remove transformer submodule

Signed-off-by: dimapihtar <[email protected]>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <[email protected]>

* fix style

Signed-off-by: dimapihtar <[email protected]>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <[email protected]>

* remove .py files

Signed-off-by: dimapihtar <[email protected]>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <[email protected]>

* remove .py files

Signed-off-by: dimapihtar <[email protected]>

* remove .py files

Signed-off-by: dimapihtar <[email protected]>

* remove .py files

Signed-off-by: dimapihtar <[email protected]>

* fix style

Signed-off-by: dimapihtar <[email protected]>

* remove nlp.modules.megatron

Signed-off-by: dimapihtar <[email protected]>

* remove nlp collection

Signed-off-by: dimapihtar <[email protected]>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <[email protected]>

* fix style

Signed-off-by: dimapihtar <[email protected]>

* fix code style

Signed-off-by: dimapihtar <[email protected]>

* fix code style

Signed-off-by: dimapihtar <[email protected]>

* fix code style

Signed-off-by: dimapihtar <[email protected]>

* fix import

Signed-off-by: dimapihtar <[email protected]>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <[email protected]>

* fix code style

Signed-off-by: dimapihtar <[email protected]>

* fix imports

Signed-off-by: dimapihtar <[email protected]>

* fix import

Signed-off-by: dimapihtar <[email protected]>

* fix imports

Signed-off-by: dimapihtar <[email protected]>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <[email protected]>

* fix imports

Signed-off-by: dimapihtar <[email protected]>

* remove unused function

Signed-off-by: dimapihtar <[email protected]>

* fix import

Signed-off-by: dimapihtar <[email protected]>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <[email protected]>

* fix imports

Signed-off-by: dimapihtar <[email protected]>

* fix unit tests

Signed-off-by: dimapihtar <[email protected]>

* fix imports

Signed-off-by: dimapihtar <[email protected]>

* fix imports

Signed-off-by: dimapihtar <[email protected]>

* fix import

Signed-off-by: dimapihtar <[email protected]>

* fix import

Signed-off-by: dimapihtar <[email protected]>

* fix code style

Signed-off-by: dimapihtar <[email protected]>

---------

Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
Co-authored-by: dimapihtar <[email protected]>
Signed-off-by: Charlie Truong <[email protected]>

* Remove HeteronymClassificationModel (#14980)

* remove HeteronymClassificationModel

Signed-off-by: Jason <[email protected]>

* pylint

Signed-off-by: Jason <[email protected]>

---------

Signed-off-by: Jason <[email protected]>
Signed-off-by: Charlie Truong <[email protected]>

---------

Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: Charlie Truong <[email protected]>
Signed-off-by: Jason <[email protected]>
Co-authored-by: Dmytro Pykhtar <[email protected]>
Co-authored-by: dimapihtar <[email protected]>
Co-authored-by: Jason <[email protected]>
AkCodes23 pushed a commit to AkCodes23/NeMo that referenced this pull request Jan 28, 2026
* move tokenizer_utils

Signed-off-by: dimapihtar <[email protected]>

* remove tokenizer_utils

Signed-off-by: dimapihtar <[email protected]>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <[email protected]>

* fix style

Signed-off-by: dimapihtar <[email protected]>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <[email protected]>

* fix style

Signed-off-by: dimapihtar <[email protected]>

* remove extra import

Signed-off-by: dimapihtar <[email protected]>

* move vocab file name

Signed-off-by: dimapihtar <[email protected]>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <[email protected]>

* remove HF imports

Signed-off-by: dimapihtar <[email protected]>

* remove hyena submodule

Signed-off-by: dimapihtar <[email protected]>

* remove transformer submodule

Signed-off-by: dimapihtar <[email protected]>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <[email protected]>

* fix style

Signed-off-by: dimapihtar <[email protected]>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <[email protected]>

* remove .py files

Signed-off-by: dimapihtar <[email protected]>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <[email protected]>

* remove .py files

Signed-off-by: dimapihtar <[email protected]>

* remove .py files

Signed-off-by: dimapihtar <[email protected]>

* remove .py files

Signed-off-by: dimapihtar <[email protected]>

* fix style

Signed-off-by: dimapihtar <[email protected]>

* remove nlp.modules.megatron

Signed-off-by: dimapihtar <[email protected]>

* remove nlp collection

Signed-off-by: dimapihtar <[email protected]>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <[email protected]>

* fix style

Signed-off-by: dimapihtar <[email protected]>

* fix code style

Signed-off-by: dimapihtar <[email protected]>

* fix code style

Signed-off-by: dimapihtar <[email protected]>

* fix code style

Signed-off-by: dimapihtar <[email protected]>

* fix import

Signed-off-by: dimapihtar <[email protected]>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <[email protected]>

* fix code style

Signed-off-by: dimapihtar <[email protected]>

* fix imports

Signed-off-by: dimapihtar <[email protected]>

* fix import

Signed-off-by: dimapihtar <[email protected]>

* fix imports

Signed-off-by: dimapihtar <[email protected]>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <[email protected]>

* fix imports

Signed-off-by: dimapihtar <[email protected]>

* remove unused function

Signed-off-by: dimapihtar <[email protected]>

* fix import

Signed-off-by: dimapihtar <[email protected]>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <[email protected]>

* fix imports

Signed-off-by: dimapihtar <[email protected]>

* fix unit tests

Signed-off-by: dimapihtar <[email protected]>

* fix imports

Signed-off-by: dimapihtar <[email protected]>

* fix imports

Signed-off-by: dimapihtar <[email protected]>

* fix import

Signed-off-by: dimapihtar <[email protected]>

* fix import

Signed-off-by: dimapihtar <[email protected]>

* fix code style

Signed-off-by: dimapihtar <[email protected]>

---------

Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
Co-authored-by: dimapihtar <[email protected]>
Signed-off-by: Akhil Varanasi <[email protected]>
nune-tadevosyan pushed a commit to nune-tadevosyan/NeMo that referenced this pull request Mar 13, 2026
* move tokenizer_utils

Signed-off-by: dimapihtar <[email protected]>

* remove tokenizer_utils

Signed-off-by: dimapihtar <[email protected]>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <[email protected]>

* fix style

Signed-off-by: dimapihtar <[email protected]>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <[email protected]>

* fix style

Signed-off-by: dimapihtar <[email protected]>

* remove extra import

Signed-off-by: dimapihtar <[email protected]>

* move vocab file name

Signed-off-by: dimapihtar <[email protected]>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <[email protected]>

* remove HF imports

Signed-off-by: dimapihtar <[email protected]>

* remove hyena submodule

Signed-off-by: dimapihtar <[email protected]>

* remove transformer submodule

Signed-off-by: dimapihtar <[email protected]>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <[email protected]>

* fix style

Signed-off-by: dimapihtar <[email protected]>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <[email protected]>

* remove .py files

Signed-off-by: dimapihtar <[email protected]>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <[email protected]>

* remove .py files

Signed-off-by: dimapihtar <[email protected]>

* remove .py files

Signed-off-by: dimapihtar <[email protected]>

* remove .py files

Signed-off-by: dimapihtar <[email protected]>

* fix style

Signed-off-by: dimapihtar <[email protected]>

* remove nlp.modules.megatron

Signed-off-by: dimapihtar <[email protected]>

* remove nlp collection

Signed-off-by: dimapihtar <[email protected]>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <[email protected]>

* fix style

Signed-off-by: dimapihtar <[email protected]>

* fix code style

Signed-off-by: dimapihtar <[email protected]>

* fix code style

Signed-off-by: dimapihtar <[email protected]>

* fix code style

Signed-off-by: dimapihtar <[email protected]>

* fix import

Signed-off-by: dimapihtar <[email protected]>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <[email protected]>

* fix code style

Signed-off-by: dimapihtar <[email protected]>

* fix imports

Signed-off-by: dimapihtar <[email protected]>

* fix import

Signed-off-by: dimapihtar <[email protected]>

* fix imports

Signed-off-by: dimapihtar <[email protected]>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <[email protected]>

* fix imports

Signed-off-by: dimapihtar <[email protected]>

* remove unused function

Signed-off-by: dimapihtar <[email protected]>

* fix import

Signed-off-by: dimapihtar <[email protected]>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <[email protected]>

* fix imports

Signed-off-by: dimapihtar <[email protected]>

* fix unit tests

Signed-off-by: dimapihtar <[email protected]>

* fix imports

Signed-off-by: dimapihtar <[email protected]>

* fix imports

Signed-off-by: dimapihtar <[email protected]>

* fix import

Signed-off-by: dimapihtar <[email protected]>

* fix import

Signed-off-by: dimapihtar <[email protected]>

* fix code style

Signed-off-by: dimapihtar <[email protected]>

---------

Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
Co-authored-by: dimapihtar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants