Fix PEFT resume with resume_from_path#14966
Merged
Merged
Conversation
Signed-off-by: Maanu Grover <[email protected]>
Collaborator
Author
|
several ways to fix this. but first time we are seeing this issue afaik, so |
resume_from_path
resume_from_pathresume_from_path
Signed-off-by: Maanu Grover <[email protected]>
ashors1
approved these changes
Oct 22, 2025
Contributor
|
[🤖]: Hi @maanug-nv 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully. So it might be time to merge this PR or get some approvals. |
quapham
pushed a commit
to quapham/NeMo
that referenced
this pull request
Dec 16, 2025
* preserve base model path for following check Signed-off-by: Maanu Grover <[email protected]> * fix import cycle Signed-off-by: Maanu Grover <[email protected]> --------- Signed-off-by: Maanu Grover <[email protected]> Signed-off-by: quanpham <[email protected]>
nune-tadevosyan
pushed a commit
to nune-tadevosyan/NeMo
that referenced
this pull request
Mar 13, 2026
* preserve base model path for following check Signed-off-by: Maanu Grover <[email protected]> * fix import cycle Signed-off-by: Maanu Grover <[email protected]> --------- Signed-off-by: Maanu Grover <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
The
Update branchbutton must only be pressed in very rare occassions.An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.
What does this PR do ?
Fixes PEFT AutoResume if checkpoint is specified with
resume_from_path.Currently, in
ckpt_to_weights_subdir()if the input filepath is anAdapterPath(this happens ifresume_from_pathpoints to a PEFT checkpoint) the following happens:filepathcopied tobase_dir(120)maybe_base_diris set, appendingWEIGHTS_PATHtobase_dirwhich losesbase_model_pathattribute (becomes None), if the input path was an AdapterPath (123)maybe_base_diris copied tobase_dir(125)base_dir.base_model_pathis None, 129 breaksCollection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information