Remove hardcoded DEBUG logging level in gpt_oss.py#15236
Merged
Conversation
459a177 to
e36d53b
Compare
The HFGPTOSSImporter.apply() method had a leftover debug statement `logging.setLevel(logging.DEBUG)` that forced verbose logging globally whenever importing GPT-OSS models from HuggingFace. This caused: - Excessive logs in production environments - Performance degradation from logging overhead - Loss of control over logging configuration The fix removes this hardcoded statement, allowing the logging level to be determined by the application's configuration. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]> Signed-off-by: yurekami <[email protected]>
e36d53b to
c3c143b
Compare
blisc
approved these changes
Jan 12, 2026
Collaborator
|
Thanks for your contribution! |
AkCodes23
pushed a commit
to AkCodes23/NeMo
that referenced
this pull request
Jan 28, 2026
NVIDIA-NeMo#15236) The HFGPTOSSImporter.apply() method had a leftover debug statement `logging.setLevel(logging.DEBUG)` that forced verbose logging globally whenever importing GPT-OSS models from HuggingFace. This caused: - Excessive logs in production environments - Performance degradation from logging overhead - Loss of control over logging configuration The fix removes this hardcoded statement, allowing the logging level to be determined by the application's configuration. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Signed-off-by: yurekami <[email protected]> Co-authored-by: yurekami <[email protected]> Co-authored-by: Claude Opus 4.5 <[email protected]> Co-authored-by: Jason <[email protected]> Signed-off-by: Akhil Varanasi <[email protected]>
nune-tadevosyan
pushed a commit
to nune-tadevosyan/NeMo
that referenced
this pull request
Mar 13, 2026
NVIDIA-NeMo#15236) The HFGPTOSSImporter.apply() method had a leftover debug statement `logging.setLevel(logging.DEBUG)` that forced verbose logging globally whenever importing GPT-OSS models from HuggingFace. This caused: - Excessive logs in production environments - Performance degradation from logging overhead - Loss of control over logging configuration The fix removes this hardcoded statement, allowing the logging level to be determined by the application's configuration. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Signed-off-by: yurekami <[email protected]> Co-authored-by: yurekami <[email protected]> Co-authored-by: Claude Opus 4.5 <[email protected]> Co-authored-by: Jason <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #15116
Removes the hardcoded
logging.getLogger("nemo").setLevel(logging.DEBUG)line that was forcing DEBUG level logging regardless of user configuration.This line overrode any user-configured logging level, making it impossible to reduce log verbosity.
Test plan