use project dir in getGitVersion #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rather than running `git describe` in the current working dir, run it in the directory of the gradle project. This allows projects that come from git submodules to use the versions from their tags.
Contributor
Author
|
I have not yet signed the Cinnober CLA, but I'll send it to you soon. |
Contributor
|
Zombiedev, have you signed the CLA and heard anything from Cinnober yet? I'm not working at Cinnober anymore but I think this should be merged and released as a bug-fix, i.e. as version 2.2.2. |
Contributor
Author
|
@mbrannstrom, I just emailed it to them. I don't know how active this project is or when they'll merge this PR, but you can always do something like this in the meantime: buildscript {
repositories {
mavenCentral()
jcenter()
maven { url "https://jitpack.io" }
}
dependencies {
classpath "com.github.zombiedev:semver-git:98f7bb63b0"
}
} |
MikaelUmaN
added a commit
that referenced
this pull request
Mar 7, 2016
use project dir in getGitVersion
Contributor
|
Thank you for your contribution. I will try to find out who are on the mailing list aforementioned and why no response was sent to you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than running
git describein the current working dir, run it inthe directory of the gradle project. This allows projects that come from
git submodules to use the versions from their repo's tags.