Codestin Search App

joseph-robertson · 2023-11-15T21:32:15Z

Pull Request Description

An alternative to #1554.

Update fuel meters such that only PV -produced electricity contributes to PV credits; essentially we're moving battery/generator accounting from "PV Credit (USD)" to "Energy (USD)". (Previously generators w/out PV weren't affecting bills at all.)
Update and create test files for demonstrating the benefit in using a battery for utility bill arbitrage.

Checklist

PR Author: Check these when they're done. Not all may apply. ~~strikethrough~~ and check any that do not apply.

PR Reviewer: Verify each has been completed.

~~Schematron validator (EPvalidator.xml) has been updated~~
Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
Documentation has been updated
Changelog has been updated
openstudio tasks.rb update_measures has been run
No unexpected changes to simulation results of sample files

…ed when battery.

…generators.

joseph-robertson · 2024-06-14T17:14:57Z

 base-bldgtype-mf-unit-shared-mechvent-preconditioning.xml,1333.3,144.0,989.28,0.0,1133.28,144.0,56.02,200.02,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,
 base-bldgtype-mf-unit-shared-mechvent.xml,1311.4,144.0,983.58,0.0,1127.58,144.0,39.82,183.82,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,
-base-bldgtype-mf-unit-shared-pv-battery.xml,385.06,144.0,978.25,-889.77,232.47,144.0,8.59,152.59,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,
+base-bldgtype-mf-unit-shared-pv-battery.xml,385.06,144.0,978.36,-889.89,232.47,144.0,8.59,152.59,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,


For any sample file w/PV, we are essentially moving some PV Credit to Energy -- in this case decreasing PV Credit and increasing Energy by the same amount. Therefore, the total remains the same.

@joseph-robertson Can you clarify the situation? You said any sample file w/ PV, but the results for base-pv.xml are unchanged.

I think I meant any sample file w/ PV + battery or generator.

jmaguire1

Arbitrage seems to be working like it's supposed to! Nice job.

Not necessarily and expert on the bill calculations but nothing jumped out at me as wrong with how you changed this around.

shorowit

Some initial review feedback.

shorowit · 2024-06-18T17:18:47Z

+base-misc-emissions.xml,892.86,144.0,1334.44,-978.65,499.79,144.0,249.07,393.07,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0
+base-misc-generators-battery-scheduled.xml,1934.97,144.0,1068.96,0.0,1212.96,144.0,338.05,482.05,0.0,239.96,239.96,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0
+base-misc-generators-battery.xml,1871.83,144.0,1005.82,0.0,1149.82,144.0,338.05,482.05,0.0,239.96,239.96,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0
+base-misc-generators.xml,1871.83,144.0,1005.82,0.0,1149.82,144.0,338.05,482.05,0.0,239.96,239.96,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0


I confirmed that this change for base-misc-generators.xml looks good.

joseph-robertson · 2024-06-20T16:22:57Z

I think that after having changed has_battery, we don't see a change in bill results for base-battery-scheduled.xml because _run_xml requests monthly timeseries anyway...

shorowit

I've looked over the results and they seem to make sense. Definitely fixes some bugs. Thanks, @joseph-robertson!

joseph-robertson added 3 commits November 15, 2023 14:20

Allow defaulting pv compensation type when battery only.

c323744

Change has_pv to has_production, and always request electricityproduc…

cad0ae9

…ed when battery.

Add sample file for scheduled battery and detailed rate scenarios.

7303c6e

joseph-robertson added the bug label Nov 15, 2023

joseph-robertson self-assigned this Nov 15, 2023

GitHub Action and others added 2 commits November 15, 2023 23:17

Latest results.

9322a7c

Stub request when generator, add notes, revert defaults changes.

feb4af6

joseph-robertson changed the title ~~ReportUtilityBills: allow detailed bill calcs for scheduled battery energy arbitrage~~ ReportUtilityBills: account for all production credit Nov 21, 2023

joseph-robertson added 3 commits November 21, 2023 08:58

Merge branch 'master' into fix-bills-scheduled-battery2

da40cd4

Revert changes to hpxml_defaults.

96db087

Merge branch 'master' into fix-bills-scheduled-battery2

39ab9f9

shorowit added the priority medium label May 28, 2024

joseph-robertson added 4 commits May 28, 2024 14:20

Merge branch 'master' into fix-bills-scheduled-battery2

a83e9fc

Run update_hpxmls on new sample file.

1271878

Merge branch 'master' into fix-bills-scheduled-battery2

2fd16f3

Remove comments and update pvcompensation defaults for batteries and …

177bea4

…generators.

joseph-robertson mentioned this pull request Jun 12, 2024

ReportUtilityBills: remove electric storage from electricity produced #1554

Closed

7 tasks

Only default grid connection if PV is present, not other production.

cd7fdbf

joseph-robertson marked this pull request as ready for review June 12, 2024 17:50

Update the changelog. [ci skip]

43ead27

joseph-robertson commented Jun 12, 2024

View reviewed changes

Comment thread Changelog.md Outdated

GitHub Action and others added 3 commits June 12, 2024 18:30

Latest results.

6e69d45

Revert default changes and change has_production bool.

5ce59b4

Revert more.

c89def3

joseph-robertson changed the title ~~ReportUtilityBills: account for all production credit~~ ReportUtilityBills: fix calculation of production credits Jun 12, 2024

joseph-robertson and others added 5 commits June 12, 2024 15:37

Update the changelog. [ci skip]

a82c3ed

Latest results.

c44e462

Try separating electric storage from produced. Again.

a085606

Avoid requesting unused meters.

f38b82f

Latest results.

5fe9b56

joseph-robertson and others added 4 commits June 14, 2024 09:15

Move cogeneration meter out of production.

4f1b58f

Update the changelog.

cc40e02

Merge branch 'master' into fix-bills-scheduled-battery2

da3f177

Latest results.

4c58736

joseph-robertson commented Jun 14, 2024

View reviewed changes

joseph-robertson and others added 2 commits June 14, 2024 11:09

Fix issue in opposite sign for storage and cogeneration production.

d27db69

Latest results.

c235b29

joseph-robertson requested a review from jmaguire1 June 14, 2024 21:40

jmaguire1 approved these changes Jun 14, 2024

View reviewed changes

joseph-robertson requested a review from shorowit June 14, 2024 22:21

joseph-robertson added 3 commits June 17, 2024 14:38

Merge branch 'master' into fix-bills-scheduled-battery2

a9f6086

Update the changelog.

7289248

Merge branch 'master' into fix-bills-scheduled-battery2

7477cee

shorowit reviewed Jun 18, 2024

View reviewed changes

joseph-robertson and others added 4 commits June 18, 2024 11:52

Merge branch 'master' into fix-bills-scheduled-battery2

5885d5d

Make has_battery consistent with has_pv and has_generator.

9f02525

Latest results.

2af2dd5

Merge branch 'master' into fix-bills-scheduled-battery2

cbb2412

joseph-robertson and others added 5 commits June 20, 2024 09:47

Revert has_battery change.

d80111e

Latest results.

45a08e9

Merge branch 'master' into fix-bills-scheduled-battery2

d8cb50b

Latest results.

62fd9f5

Simplify changelog description. [ci skip]

2a88d87

shorowit approved these changes Jun 24, 2024

View reviewed changes

shorowit merged commit 8e47f28 into master Jun 24, 2024

shorowit deleted the fix-bills-scheduled-battery2 branch June 24, 2024 22:15

joseph-robertson mentioned this pull request Jun 25, 2024

Assign detailed schedules using the lookup NatLabRockies/resstock#1166

Draft

6 tasks

joseph-robertson mentioned this pull request Jul 11, 2024

Latest OS-HPXML NatLabRockies/resstock#1268

Merged

38 tasks

willf mentioned this pull request Feb 12, 2025

Latest OS-HPXML Test-Cloned-Org/resstock#82

Open

38 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

ReportUtilityBills: fix calculation of production credits#1555

ReportUtilityBills: fix calculation of production credits#1555
shorowit merged 40 commits into
masterfrom
fix-bills-scheduled-battery2

joseph-robertson commented Nov 15, 2023 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

joseph-robertson Jun 14, 2024

Uh oh!

shorowit Jun 18, 2024

Uh oh!

joseph-robertson Jun 18, 2024

Uh oh!

Uh oh!

jmaguire1 left a comment

Uh oh!

shorowit left a comment

Uh oh!

Uh oh!

Uh oh!

shorowit Jun 18, 2024 •

edited

Loading

Uh oh!

joseph-robertson commented Jun 20, 2024

Uh oh!

shorowit left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

joseph-robertson commented Nov 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Description

Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

joseph-robertson Jun 14, 2024

Choose a reason for hiding this comment

Uh oh!

shorowit Jun 18, 2024

Choose a reason for hiding this comment

Uh oh!

joseph-robertson Jun 18, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jmaguire1 left a comment

Choose a reason for hiding this comment

Uh oh!

shorowit left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

shorowit Jun 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

joseph-robertson commented Jun 20, 2024

Uh oh!

shorowit left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

joseph-robertson commented Nov 15, 2023 •

edited

Loading

shorowit Jun 18, 2024 •

edited

Loading